Add coroutine #10
Open
Add coroutine #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
양방향 데이터 바인딩을 이용해서
양방향 데이터 바인딩을 이용해서
youngjinc
reviewed
Dec 26, 2022
| @@ -15,11 +16,11 @@ class rvAdapter(context : Context):RecyclerView.Adapter<RecyclerView.ViewHolder> | |||
| override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): RecyclerView.ViewHolder { | |||
| return when(viewType){ | |||
| REPO_TYPE ->{ | |||
| val binding = LayoutGithubRepoBinding.inflate(inflater, parent,false) | |||
| val binding = ItemUserInfoBinding.inflate(inflater, parent,false) | |||
| import timber.log.Timber | ||
|
|
||
| class LoginRepository { | ||
| suspend fun login(email: String, password: String) : Boolean= |
There was a problem hiding this comment.
Suggested change
| suspend fun login(email: String, password: String) : Boolean= | |
| suspend fun login(email: String, password: String) : Boolean = |
Goooood! 코드 정렬만 시켜주세용!
|
|
||
| class LoginRepository { | ||
| suspend fun login(email: String, password: String) : Boolean= | ||
| kotlin.runCatching { |
There was a problem hiding this comment.
Suggested change
| kotlin.runCatching { | |
| runCatching { |
| } | ||
| }) | ||
| fun login() { | ||
| viewModelScope.launch { |
Comment on lines
6
to
14
| class LoginViewModelFactory(private val loginRepository: LoginRepository):ViewModelProvider.Factory { | ||
| override fun <T : ViewModel> create(modelClass: Class<T>): T { | ||
| return if (modelClass.isAssignableFrom(LoginViewModel::class.java)) { | ||
| LoginViewModel(loginRepository) as T | ||
| } else { | ||
| throw IllegalArgumentException() | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
나중에 hilt를 쓰게된다면 Factory는 필요없게됩니다! hilt도 공부해보시면 좋을 것 같아요~
| @Body requestLoginDTO: RequestLoginDTO | ||
| ): Call<ResponseLoginDTO> | ||
| ): Response<ResponseLoginDTO> |
There was a problem hiding this comment.
Suggested change
| ): Response<ResponseLoginDTO> | |
| ): ResponseLoginDTO |
| _userInfo.value = items | ||
| } | ||
| } | ||
| } |
youngjinc
approved these changes
Dec 26, 2022
| private var items : List<ResponseUserDTO.Data> = emptyList() | ||
|
|
||
| init{ | ||
| userService.user().enqueue(object : Callback<ResponseUserDTO> { |
There was a problem hiding this comment.
함수명은 동사형태로 작성하는 것이 좋습니다! 어떤 로직을 수행하는 함수인지 알 수 있도록 구체적인 네이밍으로 수정해봅시다!!
예를들어 유저 목록을 불러오는 함수라면 fetchUser() 라는 함수명 등이 있겠어요~
login 부분만 presentation, domain, data로 폴더링해서 나눠봤어요! 아직 hilt 공부는 못했어요 ㅜㅜ
YuBeen-Park
approved these changes
Dec 29, 2022
| @@ -15,7 +15,7 @@ | |||
| android:theme="@style/Theme.INSOPTAndroidPractice" | |||
| tools:targetApi="31"> | |||
| <activity | |||
| android:name=".SignInActivity" | |||
| android:name=".presentation.SignInActivity" | |||
| } | ||
| viewModel.fatchUser() | ||
|
|
||
| viewModel.userInfo.observe(viewLifecycleOwner, Observer { |
There was a problem hiding this comment.
위에 adapter 설정해주는 부분은 initLayout()으로, 이 부분은 addObservers함수로 로직 분리해주면 좋을 거같아용!
| class LoginDataSource(private val service: ServicePool) { | ||
| suspend fun login(requestLoginDTO: RequestLoginDTO): ResponseLoginDTO = | ||
| service.loginService.login(requestLoginDTO) | ||
| } |
There was a problem hiding this comment.
저도 DataSource클래스 만들어서 다시 코드 정리해볼게요!!
| @Body requestSignupDTO: RequestSignupDTO | ||
| ): Call<ResponseSignupDTO> | ||
| ): Response<ResponseSignupDTO> |
There was a problem hiding this comment.
오호 Response로 감싸서 사용할 수도 있군요
There was a problem hiding this comment.
레트로핏이 버전업되면서 Response로 감싸지 않아도 사용가능해진 것으로 압니다!
| @@ -1,12 +1,13 @@ | |||
| package org.sopt.sample.remote | |||
|
|
|||
| import retrofit2.Call | |||
There was a problem hiding this comment.
ctrl+alt+O 단축키로 현재 사용하고 있지 않은 import 제거할 수 있어용!!
| @@ -1,9 +1,10 @@ | |||
| package org.sopt.sample.remote | |||
|
|
|||
| import retrofit2.Call | |||
| val pattern = Pattern.compile(pwPattern) | ||
| val matcher = pattern.matcher(pw) | ||
| return matcher.matches() | ||
| companion object { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.