158 fix documentation container #159
Conversation
ywkim312
requested review from
navarroc,
longshuicy,
Vismayak,
Rashmil-1999 and
ylyangtw
pyincore_viz/geoutil.py
Outdated
| from base64 import b64encode | ||
| from io import BytesIO | ||
| from pyincore_viz.plotutil import PlotUtil | ||
| from pyincore_viz.tabledatasetlistmap import TableDatasetListMap as table_list_map | ||
| from pyincore_viz.tabledatasetlistmap import TableDatasetListMap as tableListMap |
There was a problem hiding this comment.
any reason you switch to camel case? I think python convention is using underscore.
There was a problem hiding this comment.
actually i'm wondering why any of the change is needed in this file. Isn't Sphinx just parsing the docstrings?
There was a problem hiding this comment.
no this is what sphinx doc said. In fact, it worked in both way. Sphinx is not only parsing docstrings, unfortunately....
There was a problem hiding this comment.
really? but we use underscores everywhere :-(
There was a problem hiding this comment.
yes so both cases work like, I mentioned above. Do you want to change to undersocre? then I will change.
There was a problem hiding this comment.
yes could you change to underscore if possible? thanks!
removed |
It has been deployed to dev instance. https://incore-dev.ncsa.illinois.edu/doc/pyincore_viz/modules.html
When you access above url, you have to see all the components has the methods