Adds typewriter support to subtitles #3
Conversation
src/UI/SubtitleEntry.lua
Outdated
| @@ -120,6 +123,9 @@ function SubtitleEntry:UpdateMultipleText(): () | |||
| TextTransparency = 0, | |||
| }) | |||
| self.Window:UpdateSize() | |||
| if self.TypeWriterEnabled then | |||
| task.spawn(TypeWriter, self.TextLabel, Message, (self.Duration/Message:len())) | |||
There was a problem hiding this comment.
I think we use spaces around /, so self.Duration / Message:len()).
I think we also use string.len(String) instead of String:len(), so I'd think self.Duration / string.len(Message)) would be more consistent even though it is longer.
Also, does this mean the typewriter option can't handle rich text? That would need to either be handled or documented.
There was a problem hiding this comment.
Will get back to you about the rich text, as of now I've had no issues with rich text while using typewriter.
Marking this PR as a draft until I can get the proof it.
src/Util/TypeWriter.lua
Outdated
| displayText = displayText:gsub("<br%s*/>", "\n") | ||
| displayText:gsub("<[^<>]->", "") |
There was a problem hiding this comment.
Do we use String:gsub(...) in other parts of the project as opposed to string.gsub(String, ...)?
Behavior-wise, I'm not sure this properly handled mismatched tags (<a>thing</b> -> thing, when it shouldn't). Handling that may be tricky. It wasn't easy to get right in Nexus Admin for string escaping (https://github.com/TheNexusAvenger/Nexus-Admin/blob/master/src/Common/Filter.lua#L29-L42).
There was a problem hiding this comment.
Wil look into handling mismatched tags.
Adds typewriter support to subtitles, suggestion originally came from: discord
Typewriter is by default off, but can be toggled by enabling it:
Changes: