This repository has been archived by the owner on Oct 16, 2019. It is now read-only.
carousel implemented on Initiatives page #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zubairabid
suggested changes
Jan 2, 2019
There was a problem hiding this comment.
A few suggestions here
- If possible, it'd be better to have the carousel on top and the posts as they are on the current website
- Don't make the carousel that tall. Keep it to a limited height with only the image in it, cropped and centered accordingly. Link this to the post about the event (it's separate afair), or scroll down to full event description on the page
If you guys want, we could redo this entire page to make the carousel less functionally redundant. Thoughts on that if you will.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.