Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLJ Pre-publication review (1.2.0) #247

Open
MaryLJ opened this issue Dec 5, 2023 · 2 comments
Open

MLJ Pre-publication review (1.2.0) #247

MaryLJ opened this issue Dec 5, 2023 · 2 comments
Assignees
@ToddCooper
Labels
Comment Review Comment of some sort from somewhere sometime Pre-Publication Issue that needs to be resolved before the next version publication
Milestone
SDPi 2.0 Review

Comments

@MaryLJ
Copy link
Collaborator

MaryLJ commented Dec 5, 2023 •
edited
Loading

Issues/Comments

  1. On the title page, under the boxed text the starts with "Amend", in the first sentence, remove the underline bold text "some text".
  2. On title page, change "General information about IHE can be found at IHE to General information about IHE can be found at IHE.net.
  3. Section 1:2.3.13, first sentence, capitalize the word "profile" in "SDPi-P profile"
  4. Section 1:10.1, the first two paragraphs (below the boxed in text) should be combined into one paragraph.
  5. Section 1:12.1, second paragraph, second sentence, add a comma after concrete. "Actor groupings, including abstract with concrete**,** are detailed in Section 1:12.3.

##Questions

  1. For the statement on the title page "A PDF version of the specification is available upon request", who should be contacted to get a PDF?
@MaryLJ MaryLJ added Comment Review Comment of some sort from somewhere sometime Comment NEW A submitted comment waiting to be reviewed and dispositioned Pre-Publication Issue that needs to be resolved before the next version publication labels Dec 5, 2023
@MaryLJ MaryLJ mentioned this issue Dec 5, 2023
Merged
2 tasks
JavierEspina added a commit that referenced this issue Dec 7, 2023
@JavierEspina
Addressed the 5 editorial comments by Mary in #247
5832d71
@JavierEspina
Copy link
Collaborator

JavierEspina commented Dec 7, 2023 •
edited
Loading

Thank you for your comments, Mary. I just made a commit to #246 to address your 5 editorial comments.

Your question about who should be contacted for the PDF is still open though. Ultimately, and for the coming releases, it will be me generating the PDF, but I guess we should name a more official contact point in that sentence (e.g. [email protected] for IHE and [email protected] for HL7 ??). Another alternative would be to drop the PDF somewhere and point to that place. @ToddCooper / @d-gregorczyk please advise.

d-gregorczyk added a commit that referenced this issue Dec 7, 2023
@d-gregorczyk @ToddCooper @JavierEspina
Review 1.2.0 (#246)
b8182d7 
* Prepare release 1.2.0

* Updated 1.1 version notes for 1.2

Reviewed and updated all the 1.1 version notes for 1.2
Reviewed and updated all 2023 references for 2024.

* Updated a few straggling 1.1 references

All 1.1 references now updated to 1.2

* Addressed the 5 editorial comments by Mary in #247

* Prepare release 1.2.0; update changelog

* Prepare release 1.2.0; update changelog (fix)

---------

Co-authored-by: Todd "AFC!" Cooper <[email protected]>
Co-authored-by: JavierEspina <[email protected]>
@ToddCooper ToddCooper removed the Comment NEW A submitted comment waiting to be reviewed and dispositioned label Dec 8, 2023
@ToddCooper ToddCooper added this to the SDPi 1.3 Publication milestone Dec 8, 2023
@ToddCooper ToddCooper self-assigned this Nov 11, 2024
@ToddCooper ToddCooper added the Release Candidate Issue is being considered for the next release label Nov 11, 2024
@ToddCooper
Copy link
Collaborator

SDPi Workshop #4 -

Remove the sentence: A PDF version of the specification is available upon request.

@github-project-automation github-project-automation bot moved this from New issues to Done in Gemini SDPi Releases Nov 11, 2024
@ToddCooper ToddCooper reopened this Nov 11, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Gemini SDPi Releases Nov 11, 2024
@ToddCooper ToddCooper removed the Release Candidate Issue is being considered for the next release label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ToddCooper ToddCooper

Labels
Comment Review Comment of some sort from somewhere sometime Pre-Publication Issue that needs to be resolved before the next version publication
Projects
Gemini SDPi Releases
Status: In Progress
Milestone
SDPi 2.0 Review
Development

No branches or pull requests
3 participants
@ToddCooper @MaryLJ @JavierEspina