Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review 1.2.0 #246

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Review 1.2.0 #246

merged 7 commits into from
Dec 7, 2023

Conversation

d-gregorczyk
Copy link
Collaborator

@d-gregorczyk d-gregorczyk commented Dec 4, 2023

☑ Mandatory Tasks

The following aspects have been respected by the pull request assignee and at least one reviewer:

  • Changelog update (necessity checked and entry added or not added respectively)
    • Pull Request Assignee
    • Reviewer

d-gregorczyk and others added 3 commits November 29, 2023 17:11
Reviewed and updated all the 1.1 version notes for 1.2
Reviewed and updated all 2023 references for 2024.
All 1.1 references now updated to 1.2
Copy link
Collaborator

@MaryLJ MaryLJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments in issue #247

@JavierEspina
Copy link
Collaborator

@d-gregorczyk, this looks almost ready, pending the clarification of one last detail in #247. I see there are conflicts again in the changelog file. Can you please take care of that? Whenever I have tried to do that I have messed up (or it was my IDE... I like to think).

@d-gregorczyk
Copy link
Collaborator Author

@d-gregorczyk, this looks almost ready, pending the clarification of one last detail in #247. I see there are conflicts again in the changelog file. Can you please take care of that? Whenever I have tried to do that I have messed up (or it was my IDE... I like to think).

Thank you Javier for taking action! I am going to solve the merge conflict and run the release now.

@d-gregorczyk d-gregorczyk self-assigned this Dec 7, 2023
@d-gregorczyk d-gregorczyk merged commit b8182d7 into master Dec 7, 2023
1 check passed
@d-gregorczyk d-gregorczyk deleted the review-1.2.0 branch December 7, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants