Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend GECKO with Maelstrom terms #13

Merged
merged 3 commits into from
Sep 7, 2020
Merged

Extend GECKO with Maelstrom terms #13

merged 3 commits into from
Sep 7, 2020

Conversation

beckyjackson
Copy link
Collaborator

See full set of new term additions in #11

The four NTRs for EUPATH have temporary IDs that shouldn't be merged. Depending on if EUPATH wants these terms (VEuPathDB-ontology/VEuPathDB-ontology#84), we will update to the EUPATH ID or assign a new GECKO ID.

Note that I've also moved all external terms to the external sheet, since we have quite a few now.

@beckyjackson beckyjackson marked this pull request as draft August 26, 2020 15:41
@beckyjackson beckyjackson marked this pull request as ready for review September 2, 2020 13:40
@beckyjackson beckyjackson marked this pull request as draft September 2, 2020 13:40
@beckyjackson
Copy link
Collaborator Author

beckyjackson commented Sep 2, 2020

This is more or less ready, but there are a couple terms that use temporary EUPATH IDs (like GECKO:EUPATH_1) while we wait to see if EUPATH wants to add them or not. Do we want to just give these GECKO IDs for now?

Alternatively, we could just remove them for now.

@beckyjackson
Copy link
Collaborator Author

Looks like those EUPATH terms are being redirected to ENVO - EnvironmentOntology/envo#1008

@mcourtot
Copy link
Contributor

mcourtot commented Sep 3, 2020

Hi @beckyjackson : thinking about writing a paper about this in short term. Is there a way to keep track of this kind of detailed work (enriching/coordinating with other resources) as it'd be good to report on it. There is probably other pieces to think about, so a list somewhere could really help to remember.

@beckyjackson
Copy link
Collaborator Author

@mcourtot I can absolutely make a Google Spreadsheet with all the terms we've added and where they came from, or similar terms. Would that be useful?

@beckyjackson
Copy link
Collaborator Author

I've removed those temporary EUPATH terms from this PR. We can add them as soon as they are added to EUPATH/ENVO in a separate PR. This is ready to go.

@beckyjackson beckyjackson marked this pull request as ready for review September 7, 2020 16:09
@jamesaoverton jamesaoverton merged commit f9e95e1 into master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants