Skip to content

Conversation

jmkerloch
Copy link
Collaborator

@jmkerloch jmkerloch commented Apr 5, 2023

closes #63

Documentation

  • update api.yaml with new route /services/{service}/projections/{projection}
    • for now only returning projection id in response. Waiting for PR for projection params get from projectionManager to add projection param to response

Code

  • add support for error catch for IPC service:
    • add _uuid to error before send to catch it in serviceProcess
    • add _errorFlag to error so serviceProcess can define if an error was returned
    • throw error with errorManager
  • define new class projectionRequest / projectionResponse
  • add route inside the router:
    • update controller to check for request param for projection and create projection response
  • add new function computeRequest() in administrator to pass request to serviceManager
  • add computeProjectionRequest in service to check wanted projection

@jmkerloch jmkerloch marked this pull request as ready for review April 5, 2023 13:03
@jmkerloch jmkerloch added this to the sprint4 milestone Apr 5, 2023
@jmkerloch jmkerloch requested a review from lgrd April 5, 2023 13:04
@jmkerloch jmkerloch self-assigned this Apr 5, 2023
@jmkerloch jmkerloch added the enhancement New feature or request label Apr 5, 2023
@lgrd
Copy link
Contributor

lgrd commented Apr 5, 2023

I think you forgot the changelog ;)

@jmkerloch jmkerloch requested a review from lgrd April 6, 2023 07:07
Copy link
Contributor

@lgrd lgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ! :)

@jmkerloch jmkerloch merged commit 5468a4d into develop Apr 6, 2023
@jmkerloch jmkerloch deleted the feature/add_route_for_service_projections branch April 6, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] /services/{service}/projections/{projection} implementation (1/2)
2 participants