Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(admin): add route to restart service #53

Merged
merged 8 commits into from
Mar 24, 2023
Merged

feat(admin): add route to restart service #53

merged 8 commits into from
Mar 24, 2023

Conversation

benoitblanc
Copy link
Contributor

Closes #45

@benoitblanc benoitblanc marked this pull request as ready for review March 20, 2023 15:07
@benoitblanc benoitblanc requested review from lgrd and jmkerloch March 20, 2023 15:07
@lgrd
Copy link
Collaborator

lgrd commented Mar 21, 2023

Hello, I'm testing and trying some stuff. ;)

lgrd
lgrd previously approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@lgrd lgrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi ! The code is ok but you forgot to update the unit/integration tests and some docs. we all did ;)
On the code, I've changed some use of Promises to fit in the rest of the code. We can talk about that via zoom if you want.

@lgrd lgrd merged commit 47188a1 into develop Mar 24, 2023
@jmkerloch jmkerloch added this to the sprint4 milestone Apr 5, 2023
@jmkerloch jmkerloch deleted the feature/route_restart_service branch April 6, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgrd lgrd lgrd approved these changes

@jmkerloch jmkerloch Awaiting requested review from jmkerloch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
sprint4
Development

Successfully merging this pull request may close these issues.

[feat] /services/{service}/restart implementation
3 participants
@benoitblanc @lgrd @jmkerloch