Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: allow inference for smallest clouds possible + addresses many smaller issues. #81

Merged
merged 17 commits into from
Aug 9, 2023

Conversation

CharlesGaydon
Copy link
Collaborator

@CharlesGaydon CharlesGaydon commented Aug 1, 2023

Goal : accept patches of data with the minimal number of nodes i.e. 1 node.
Until now we would disregard patches with less than 50 nodes (points). But the model architecture is designed to accept such cases, which is useful to avoid null predictions in e.g. water areas.

There was an issue with the standardization of intensity / average colors when num_nodes was equal to 1 (then : std is undefined). This is now fixed and any any patch with at least 1 node is accepted and can have an inference.

Empty patches are still ignored.

This should fix #79


Additionnally this branch turned into a dev branch with other additions:

@CharlesGaydon CharlesGaydon changed the title Fix inference when num nodes is one Allow inference for the smallest possible patches (num_nodes=1) to have consistent inference behavior Aug 1, 2023
@CharlesGaydon CharlesGaydon force-pushed the fix-inference-when-num_nodes-is-one branch from a79cc79 to c07b570 Compare August 1, 2023 09:28
@CharlesGaydon
Copy link
Collaborator Author

rebased pour ne garder que le changement de la minor version.

@CharlesGaydon
Copy link
Collaborator Author

Error due to docker mount. I deleted the image and ran the tests again...

@CharlesGaydon
Copy link
Collaborator Author

Simply a store mount error due to a bad network (I cannot ping store.ign.fr). I unmounted the store and will need to mount it back when the connection is back on.

@CharlesGaydon
Copy link
Collaborator Author

Last commit fixes #60

@CharlesGaydon CharlesGaydon linked an issue Aug 2, 2023 that may be closed by this pull request
@CharlesGaydon CharlesGaydon linked an issue Aug 2, 2023 that may be closed by this pull request
@CharlesGaydon
Copy link
Collaborator Author

last commit fixes #68

@CharlesGaydon CharlesGaydon linked an issue Aug 2, 2023 that may be closed by this pull request
@CharlesGaydon
Copy link
Collaborator Author

Last commit fixes: #69

@CharlesGaydon
Copy link
Collaborator Author

Last commit addresses #75

@CharlesGaydon CharlesGaydon changed the title Allow inference for the smallest possible patches (num_nodes=1) to have consistent inference behavior Dev: allow inference for smallest clouds possible + addresses many smaller issues. Aug 2, 2023
.github/workflows/cicd.yaml Show resolved Hide resolved
myria3d/pctl/dataset/utils.py Show resolved Hide resolved
myria3d/pctl/dataset/utils.py Outdated Show resolved Hide resolved
run.py Show resolved Hide resolved
@CharlesGaydon
Copy link
Collaborator Author

@leavauchier J'ai rétabli les tests unitaires. Le store est toujours inacessible mais le reste des tests passe.

@CharlesGaydon CharlesGaydon merged commit b4d2ef8 into main Aug 9, 2023
1 check failed
@CharlesGaydon CharlesGaydon deleted the fix-inference-when-num_nodes-is-one branch August 9, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment