Skip to content

fix(yuv): set luma offset default to 0 for proper scale behavior #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
for13to1 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(yuv): set luma offset default to 0 for proper scale behavior #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions YUViewLib/src/video/yuv/videoHandlerYUV.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2385,7 +2385,7 @@ std::vector<PixelFormatYUV> videoHandlerYUV::formatPresetList = {
videoHandlerYUV::videoHandlerYUV() : videoHandler()
{
// Set the default YUV transformation parameters.
this->conversionSettings.mathParameters[Component::Luma] = MathParameters(1, 125, false);
this->conversionSettings.mathParameters[Component::Luma] = MathParameters(1, 0, false);
this->conversionSettings.mathParameters[Component::Chroma] = MathParameters(1, 128, false);

// If we know nothing about the YUV format, assume YUV 4:2:0 8 bit planar by default.
Expand Down Expand Up @@ -2597,8 +2597,7 @@ void videoHandlerYUV::setSrcPixelFormat(PixelFormatYUV format, bool emitSignal)
// Update the math parameter offset (the default offset depends on the bit depth and the range)
int shift = format.getBitsPerSample() - 8;
const bool fullRange = isFullRange(this->conversionSettings.colorConversion);
this->conversionSettings.mathParameters[Component::Luma].offset = (fullRange ? 128 : 125)
<< shift;
this->conversionSettings.mathParameters[Component::Luma].offset = 0 << shift;
this->conversionSettings.mathParameters[Component::Chroma].offset = 128 << shift;

if (ui.created())
Expand Down Expand Up @@ -3765,7 +3764,7 @@ QImage videoHandlerYUV::calculateDifference(FrameHandler *item2,
{
// Get the format of the tmpDiffYUV buffer and convert it to RGB
ConversionSettings conversionSettings;
conversionSettings.mathParameters[Component::Luma] = MathParameters(1, 125, false);
conversionSettings.mathParameters[Component::Luma] = MathParameters(1, 0, false);
conversionSettings.mathParameters[Component::Chroma] = MathParameters(1, 128, false);
convertYUVPlanarToRGB(
diffYUV, outputImage.bits(), Size(w_out, h_out), tmpDiffYUVFormat, conversionSettings);
Expand Down