Skip to content

Hotfix for env settings and deps #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 3, 2025
Merged

Hotfix for env settings and deps #560

merged 10 commits into from
Oct 3, 2025

Conversation

tonyzhao6
Copy link
Contributor

Reviewer: @lickem22
Estimate: ~10 minutes

Description

  1. Updated dependencies, make targets, and .env files to reflect current conditions.

How has this been tested?

  1. Both @lickem22 and @tonyzhao6 verified new setup working locally.
  2. GHA to verify if CI passes.

Checklist

Fill with x for completed.

  • My code follows the style guidelines of this project
  • I have reviewed my own code to ensure good quality
  • I have tested the functionality of my code to ensure it works as intended
  • I have resolved merge conflicts

(Delete any items below that are not relevant)

  • I have updated the requirements

lickem22
lickem22 reviewed Oct 1, 2025
View reviewed changes
lickem22
lickem22 reviewed Oct 1, 2025
View reviewed changes
lickem22
lickem22 approved these changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@lickem22 lickem22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of comments.

@tonyzhao6 tonyzhao6 merged commit c902d3c into main Oct 3, 2025
4 checks passed
@tonyzhao6 tonyzhao6 deleted the tz6/french branch October 3, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lickem22 lickem22 lickem22 approved these changes

@sidravi1 sidravi1 Awaiting requested review from sidravi1 sidravi1 is a code owner

@suzinyou suzinyou Awaiting requested review from suzinyou suzinyou is a code owner

@amiraliemami amiraliemami Awaiting requested review from amiraliemami amiraliemami is a code owner

@poornimaramesh poornimaramesh Awaiting requested review from poornimaramesh poornimaramesh is a code owner

@markbotterill markbotterill Awaiting requested review from markbotterill markbotterill is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tonyzhao6 @lickem22