update iptables role #440
Merged
update iptables role #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
reviewed
Nov 4, 2024
There was a problem hiding this comment.
The change fixes the failing Molecule tests currently failing on the HEAD of this repository. Has this been validated functionally in a pilot or production environment?
One comment on the underlying PR - ome/ansible-role-iptables-raw#13 (review). Once the change is validated, I think the progression will be to get the underlying role PR released with the change, update this PR and merge it.
|
Deployed on |
This was referenced Nov 11, 2024
Merged
sbesson
previously approved these changes
Nov 20, 2024
sbesson
requested changes
Nov 20, 2024
Use the new version of the ome.iptables_raw role
sbesson
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the iptables deployment issue by using the iptables_raw role from this ome/ansible-role-iptables-raw#13.
It is extracted from #438.