-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controller for cia402 drives #61
base: main
Are you sure you want to change the base?
Conversation
@mcbed we had some success with using the perform-switch function in system interface in ros2_canopen. It switches the mode depending on the claimed interface. This has the advantage that you can achieve behavior similar to a robot driver (e.g. ur). Probably depends on the targeted use case. |
@ipa-cmh thanks for the hint, we will try to add this feature in the near future together with lifecycle management in ros2_control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems there is a mismatch in amount of command interfaces and the offset when targeting each command interface
{ | ||
controller_interface::InterfaceConfiguration conf; | ||
conf.type = controller_interface::interface_configuration_type::INDIVIDUAL; | ||
conf.names.reserve(dof_names_.size() * 2); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be * 3
} | ||
} | ||
|
||
command_interfaces_[2 * i + 1].set_value(mode_ops_[i]); // mode_of_operation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 *
} | ||
|
||
command_interfaces_[2 * i + 1].set_value(mode_ops_[i]); // mode_of_operation | ||
command_interfaces_[2 * i + 2].set_value(reset_faults_[i]); // reset_fault |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 *
Works good for me with the changes above. |
This PR resolves issue #46.
Controller features for
ec_generic_cia402
:status_word
mode_of_operation
mode_of_operation
using servicesfault_reset
service