Draft: Unsafe OpenMP operations -- part 2 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to the error detected in #93 and fixed in 511767e, but with the difference that in this case it doesn't seem to cause issues in real life, as most probably at this point of the execution thread #0 of the newly created team corresponds to the main thread executing the rest of the code, so the write to nthreads *is* visible. Signed-off-by: Rodrigo Tobar <[email protected]>
These three variables were not used in SearchBaryons, so they only add noise. Also, if nthreads and maxthreads were used they would have run into similar problems to those fixed in 511767e. Signed-off-by: Rodrigo Tobar <[email protected]>
3d-runRelevant configuration parameters full file:
R_200crit v/s Mass_200crit: R_200mean v/s Mass_200mean: Mass_200crit histogram: Mass_200mean histogram: R_200crit histogram: R_200mean histogram: 6d-runRelevant configuration parameters full file:
R_200crit v/s Mass_200crit: R_200mean v/s Mass_200mean: Mass_200crit histogram: Mass_200mean histogram: R_200crit histogram: R_200mean histogram: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are similarly unsafe operations around OpenMP like those reported in #93, which I found after a quick grep around the code. In most cases the OpenMP infrastructure wasn't even being used, so most of the diff is just code removal.