Add deprecated synonyms to removed params #703
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abouteiller
added
documentation
bosilca
reviewed
Nov 18, 2024
| "-1: do not bind." | ||
| "Warning: binding relies on HWLOC, be careful when using with cgroups", | ||
| false, false, comm_binding_parameter, &comm_binding_parameter); | ||
| parsec_mca_param_reg_syn_name(idx, "parsec", "bind_comm", true); |
There was a problem hiding this comment.
we have parsec_bin_main_thread and parsec_bin_comm ? Make it parsec_bind_comm_thread to be similar.
There was a problem hiding this comment.
I updated the description to explain: the synonyms are reintroduced for the only purpose of complaining if they are used, and they are expected to be inconsistent (reason they got removed in the first place)
There was a problem hiding this comment.
Since I get you, the synonym registration with deprecated=true does not cause a warning to be issued when the mca is used, but only when calling mca_show_params does a warning get issued. Am I using this wrong?
| false, false, dot_param, &dot_param); | ||
| parsec_mca_param_reg_syn_name(idx, "parsec", "dot", true); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These synomyms are inconsistent (that's the reason they got removed in the first place). They are reintroduced only for the purpose of complaining when they are used instead of being silently ignored.