fixrule(input_label_visible, input_placeholder_label_visible, input_checkboxes_grouped): tight the scope of the rules and merge help
#1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5c39330.
shunguoy
changed the title
input_label_visible, input_placeholder_label_visible, input_checkboxes_grouped): tight the scopes of the rulesinput_label_visible, input_placeholder_label_visible, input_checkboxes_grouped): tight the scope of the rules
merge help from two files
philljenkins
changed the title
input_label_visible, input_placeholder_label_visible, input_checkboxes_grouped): tight the scope of the rulesinput_label_visible, input_placeholder_label_visible, input_checkboxes_grouped): tight the scope of the rules and merge help
|
After help and rules changes, the rule is correctly display in the Rule Set listing
|
tombrunet
approved these changes
Jul 20, 2024
|
Under test |
|
Additional information is require for validation. |
|
Validated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the following issue(s):
Fixes #1625
Fixes #1621
Fixes #1623
Fixes #1946
Testing reference:
Test case for Revisit: input_label_visible - can we tighten scope? #1623 (Input_label_visible) & Revisit: input_placeholder_label_visible - can we tighten scope? #1625 (Input_placeholder_visible): test/v2/checker/accessibility/rules/input_label_visible_ruleunit/elements_visible_label.html
filter to the Requirements for 3.3.2 Labels or Instructions
Original: 9 NR respectively from the Input_label_visible & Input_placeholder_visible rules
After fix: 6 NR left from the Input_label_visible rule the original Input_placeholder_visible rule was merged to Input_label_visible rule. Notice that the messages were changed too.
The change for Revisit: input_checkboxes_grouped - can we tighten scope? #1621 (input_checkboxes_grouped) was on the styles, the code logic doesn’t change so the result should be the same (see test case: test/v2/checker/accessibility/rules/input_checkboxes_grouped_ruleunit/AllFailures.html).
View new merged help for formatting and valid links (screenshots in issues)
I have conducted the following for this PR: