Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(input_onchange_review): Update the input types and messages #1928

Merged
merged 8 commits into from
Jun 27, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Jun 11, 2024

  • New or modified help files: input_onchange_review
  • Rule bug: input_onchange_review

This PR is related to the following issue(s):

Fixes #1624
Fixes #1929 Help

Testing reference:

test case: test/v2/checker/accessibility/rules/input_onchange_review_ruleunit/Input-types.html
After the fixes, several NR messages: "Confirm that the user is advised if, due to a change of element value, a form automatically submits, a new window opens, or a change in focus occurs"

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@philljenkins philljenkins linked an issue Jun 13, 2024 that may be closed by this pull request
@shunguoy shunguoy requested a review from tombrunet June 19, 2024 16:19
@shunguoy shunguoy marked this pull request as ready for review June 19, 2024 16:19
@ErickRenteria
Copy link
Contributor

Validated
Screenshot 2024-06-26 at 8 09 39 PM

@ErickRenteria ErickRenteria merged commit 166ec4f into master Jun 27, 2024
15 checks passed
@tombrunet tombrunet deleted the dev-1624 branch August 2, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants