Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixrule(input_haspopup_conflict): Add additional checks and update the messages #1917

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

shunguoy
Copy link
Contributor

@shunguoy shunguoy commented Jun 5, 2024

  • New or modified help files: input_haspopup_conflict
  • Rule bug: input_haspopup_conflict

This PR is related to the following issue(s):

Fixes: #1622
Fixes: #1915 Hellp

Testing reference:

test case: test/v2/checker/accessibility/rules/input_haspopup_conflict_ruleunit/input_list_other.html
After the fix two new violations appear:
"The list attribute for the element is invalid"
"The list attribute for the element does not reference a datalist element"

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@shunguoy shunguoy linked an issue Jun 5, 2024 that may be closed by this pull request
1 task
@philljenkins philljenkins changed the title fixrule(input_haspopup_conflict) Add additional checks and update the messages fixrule(input_haspopup_conflict): Add additional checks and update the messages Jun 6, 2024
@shunguoy shunguoy marked this pull request as ready for review June 18, 2024 21:46
@ErickRenteria
Copy link
Contributor

Validated
Screenshot 2024-06-26 at 7 44 15 PM

@ErickRenteria ErickRenteria merged commit ee397d5 into master Jun 27, 2024
15 checks passed
@tombrunet tombrunet deleted the dev-1622 branch August 2, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help: input_haspopup_conflict needs updating Revisit: input_haspopup_conflict - can we tighten scope?
4 participants