Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): refactor duplicated replica+partition logic #2925

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(client): refactor duplicated replica+partition logic #2925

wants to merge 2 commits into from

Conversation

Trinoooo
Copy link

  1. extract the same logic in Replicas, InSyncReplicas, OfflineReplicas. Improve reusability, maintainability, and consistency
  2. remove unnecessary local variable and misleading annotion. see Sincerely ask, is this redundant? #2923

@Trinoooo
fix(client): refactor duplicated replica logic
57b9397 
1. extract the same logic in Replicas, InSyncReplicas, OfflineReplicas.
   Improve reusability, maintainability, and consistency
2. remove unnecessary local variable and misleading annotation. see
   IBM#2923

Signed-off-by: Trino <[email protected]>
@Trinoooo
fix(client): refactor duplicated partition logic
496e760 
extract the same logic in Partitions and WritablePartitions

Signed-off-by: Trino <[email protected]>
@dnwe dnwe force-pushed the style/eliminate_redundancies_and_misunderstandings branch from a1fb1e9 to 7dc5281 Compare August 7, 2024 16:51
puellanivis
puellanivis reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@puellanivis puellanivis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all reasonable to me.

@dnwe dnwe force-pushed the style/eliminate_redundancies_and_misunderstandings branch 4 times, most recently from 18da12b to fdfd7a4 Compare August 12, 2024 18:27
@dnwe dnwe changed the title style: eliminate redundancies and remove misleading annotion chore(client): refactor duplicate replica logic into shared func Aug 13, 2024
@dnwe dnwe changed the title chore(client): refactor duplicate replica logic into shared func fix(client): refactor duplicated replica+partition logic Aug 13, 2024
@dnwe dnwe force-pushed the style/eliminate_redundancies_and_misunderstandings branch from fdfd7a4 to 496e760 Compare August 13, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puellanivis puellanivis puellanivis left review comments

@dnwe dnwe dnwe approved these changes

Assignees
No one assigned
Labels
housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trinoooo @dnwe @puellanivis