add daemon() implementation #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I guess I could have just taken the current BSD implementation: |
Member
Author
kadler
reviewed
Nov 3, 2022
Comment on lines
+48
to
+53
| for (int i = 0; i <= 2; ++i) | ||
| { | ||
| if (-1 == dup2(devnull, i)) | ||
| { | ||
| return -1; | ||
| } |
Member
Member
There was a problem hiding this comment.
AFAICT, the only error that really could occur here is EINTR which we could handle better anyway. EBADF and EMFILE should never happen.
| #include <fcntl.h> | ||
|
|
||
| // Modeled after doc at https://man7.org/linux/man-pages/man3/daemon.3.html | ||
| static int libutil_daemon(int nochdir, int noclose) |
Member
There was a problem hiding this comment.
Suggested change
| static int libutil_daemon(int nochdir, int noclose) | |
| int libutil_daemon(int nochdir, int noclose) | |
If this is a public API it shouldn't be static.
| } | ||
| } | ||
| return 0; | ||
| } No newline at end of file |
Comment on lines
+27
to
+31
| int devnull = open("/dev/null", O_RDWR); | ||
| if (-1 == devnull) | ||
| { | ||
| return -1; | ||
| } |
Member
There was a problem hiding this comment.
This should be moved inside the noclose block below. It also needs to be closed after the dup2 calls.
| cp perfstat/libiperf.h $(DESTDIR)$(PREFIX)/include/libiperf.h | ||
|
|
||
| util/libutil.o: util/getopt_long.o util/pty.o util/mkdtemp.o util/backtrace.o util/bsd-flock.o util/asprintf.o util/progname.o util/err.o util/isatty.o | ||
| util/libutil.o: util/getopt_long.o util/pty.o util/mkdtemp.o util/backtrace.o util/bsd-flock.o util/asprintf.o util/progname.o util/err.o util/isatty.o util/daemon.o |
Member
There was a problem hiding this comment.
Looks like you manually updated the Makefile. You need to update build.json then re-run autogen.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based loosely on the doc at https://man7.org/linux/man-pages/man3/daemon.3.html