Package all js libs#5481
Open
gcgoncalves wants to merge 6 commits into
Open
Conversation
gcgoncalves
force-pushed
the
packaje-ALL-js-libs
branch
from
45c9400 to
8faa479
Compare
gcgoncalves
requested review from
Lang-Akshay,
brian-hussey,
crivetimihai,
ja8zyjits and
msureshkumar88
as code owners
madhu-mohan-jaishankar
requested changes
Jul 2, 2026
| window.htmxConfig.inlineScriptNonce = "{{ csp_nonce(request) }}"; | ||
| </script> | ||
| <script defer src="{{ root_path }}/static/{{ bundle_js }}"></script> | ||
| <script type="module" src="{{ root_path }}/static/{{ bundle_js }}"></script> |
Collaborator
There was a problem hiding this comment.
Since this PR removes the vendored asset download/build path, I think the ui_airgapped branch here may need to be updated too. It still references /static/vendor/..., so offline mode appears to depend on files that is no longer produced.
Collaborator
There was a problem hiding this comment.
Could you also update the packages in this PR? Please?
npm update
npm audit
npm audit fix
46 tasks
gcgoncalves
force-pushed
the
packaje-ALL-js-libs
branch
from
2762e0b to
035aaec
Compare
35 tasks
Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
gcgoncalves
force-pushed
the
packaje-ALL-js-libs
branch
from
035aaec to
f541c55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🔗 Related Issue
Closes https://github.ibm.com/contextforge-org/internal_issues/issues/387
📝 Summary
Packages all JS packages, and then chunks the package to prevent a massive bundle.
📏 Reviewability
triage🏷️ Type of Change
🧪 Verification
Run
make build-ui devthen test the app on localhost. Make sure there are no errors on the browser console.make lintmake testmake coverage✅ Checklist
make black isort pre-commit)