Skip to content

Conversation

madhav165
Copy link
Collaborator

@madhav165 madhav165 commented Oct 6, 2025

🐛 Bug-fix PR


📌 Summary

Gateway addition from UI is broken after admin API started treating any gateway with oauth_config as an oauth gateway. This was because UI was sending oauth_grant_type as authorization_code for all gateways irrespective of gateway auth_type. This led to all gateways being treated as oauth gateways.

💡 Fix Description

Makes oauth_grant_type as '' when auth_type in gateway submit and edit forms is ''.

🧪 Verification

Check Command Status
Lint suite make lint pass
Unit tests make test pass
Manual regression no longer fails steps / screenshots Tested with sse server with no auth

📐 MCP Compliance (if relevant)

  • No breaking change to MCP clients

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • No secrets/credentials committed

Signed-off-by: Madhav Kandukuri <[email protected]>
Copy link
Member

@kevalmahajan kevalmahajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tools are now fully populated for the added MCP server, and everything is fixed and works when authentication is not OAuth.

@kevalmahajan kevalmahajan merged commit 0d9a23e into main Oct 7, 2025
36 checks passed
@kevalmahajan kevalmahajan deleted the fix-gateway-add branch October 7, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants