Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(progressbar): wrongly showing ok button instead of cancel #235

Merged
merged 1 commit into from
Mar 6, 2025
Merged

fix(progressbar): wrongly showing ok button instead of cancel #235

merged 1 commit into from
Mar 6, 2025

Conversation

SMartorelli
Copy link
Member

General Updates

Bug Fixes

Pre-launch Checklist

  • I read the Code of Conduct and followed the process outlined there for submitting PRs.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I updated README.md file with new version/info - if applicable.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@SMartorelli SMartorelli added the bug Something isn't working label Mar 6, 2025
@SMartorelli SMartorelli self-assigned this Mar 6, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@SMartorelli SMartorelli requested a review from jvalentik March 6, 2025 08:24
jvalentik
jvalentik approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@jvalentik jvalentik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jvalentik jvalentik merged commit d702873 into main Mar 6, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvalentik jvalentik jvalentik approved these changes

Assignees

@SMartorelli SMartorelli

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Popup with progress bar not displaying cancel
2 participants
@SMartorelli @jvalentik