Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isolate script should check if cert manager is requested before isolation #2307

Open
wants to merge 2 commits into
base: scripts-dev
Choose a base branch
from

Conversation

qpdpQ
Copy link
Contributor

@qpdpQ qpdpQ commented Nov 15, 2024

What this PR does / why we need it:
Base on comment: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/65281#issuecomment-96802240

  • isolate.sh requests and checks cert manager before and after isolation IFF ibm-cert-manager-operator is requested via OperandRequest in the tenant before isolation.
    • isolate.sh would check a cert manager presenting BEFORE isolation if any OperandRequest in the tenant contains operand ibm-cert-manager-operator.
      • if no ibm-cert-manager-operator is requested in OperandRequest, skip checking if cert manager deployment in the cluster
    • isolate.sh would wait for cert manager presenting AFTER isolation only if isolate.sh checked cert manager presenting before isolation.

Which issue(s) this PR fixes:
Fixes # https://github.ibm.com/IBMPrivateCloud/roadmap/issues/65281

Special notes for your reviewer:

  1. How the test is done?

How to backport this PR to other branch:

  1. Add label to this PR with the target branch name backport <branch-name>
  2. The PR will be automatically created in the target branch after merging this PR
  3. If this PR is already merged, you can still add the label with the target branch name backport <branch-name> and leave a comment /backport to trigger the backport action

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qpdpQ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Allen Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants