Update README.md for rep_removal to mention memory requirement #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Is it worth calling out limit on size of file which can be processed with 16GB in readme? or that does not matter? |
We don't know the size limit that causes the crash on my machine (that has 16GB), but the random file we downloaded from HF, before resizing, crashed my laptop. I think we should leave the comment as is, without knowing more details. The same file does not crash 32GB machines. |
|
How about this then - we dont mention size at all ? |
|
Thanks, @agoyal26. Good suggestions. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1035