Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update code transforms the support new api #1023

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

shivdeep-singh-ibm
Copy link
Collaborator

Why are these changes needed?

Related issue number (if any).

@shivdeep-singh-ibm shivdeep-singh-ibm self-assigned this Feb 7, 2025
@shivdeep-singh-ibm shivdeep-singh-ibm changed the title [DRAFT] update code transforms ti support new api [DRAFT] update code transforms the support new api Feb 7, 2025
@touma-I touma-I requested a review from revit13 March 6, 2025 12:04
Copy link
Collaborator

@touma-I touma-I left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivdeep-singh-ibm thanks you being thorough with this migration.

FROM ${BASE_IMAGE}

# see https://docs.openshift.com/container-platform/4.17/openshift_images/create-images.html#use-uid_create-images
USER root
RUN chown ray:root /home/ray && chmod g=u /home/ray
RUN chown ray:root /home/ray && chmod 775 /home/ray
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We encountered permissions issues running on OpenShift and using g=u fixed that according to this link. I suggest testing it on Openshift cluster first... Thanks cc @roytman

@touma-I touma-I requested a review from shahrokhDaijavad March 6, 2025 23:23
@shahrokhDaijavad
Copy link
Member

shahrokhDaijavad commented Mar 6, 2025

@touma-I Notebooks are all there, but they are the absolute minimum! README's are missing. I will work on the READMEs.

- update code2parquet, license_select and proglang-select with README and notebooks.

Signed-off-by: Shivdeep Singh <[email protected]>
@shivdeep-singh-ibm shivdeep-singh-ibm changed the title [DRAFT] update code transforms the support new api update code transforms the support new api Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants