Skip to content

Make daemonset mountPropagation configurable, remove bidirectional default #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlubins wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −0
Open

Make daemonset mountPropagation configurable, remove bidirectional default #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions charts/core-dump-handler/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,7 @@ Daemonset
* envFrom: Array of [EnvFromSource](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#envfromsource-v1-core) to inject into main container.
* sidecarContainers: Array of [Container](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#container-v1-core) to define as part of the pod.
* updateStrategy: [DaemonsetUpdateStrategy](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#daemonsetupdatestrategy-v1-apps) is a struct used to control the update strategy for the DaemonSet.
* mountPropagation: [Mount propagation](https://kubernetes.io/docs/concepts/storage/volumes/#mount-propagation) mode for core dump volumes. (Default "")

Service account:
* useToken: automatically create a service account token secret
Expand Down
18 changes: 18 additions & 0 deletions charts/core-dump-handler/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,24 @@ Basically copied from https://github.com/bitnami/charts/blob/master/bitnami/comm
mountPath: {{ .Values.daemonset.eventDirectory }}
mountPropagation: Bidirectional
{{- end }}
{{- define "core-dump-handler.daemonset.container.volumeMounts" -}}
- name: host-volume
mountPath: {{ .Values.daemonset.hostDirectory }}
{{- if .Values.daemonset.mountPropagation }}
mountPropagation: {{ .Values.daemonset.mountPropagation }}
{{- end }}
- name: core-volume
mountPath: {{ .Values.daemonset.coreDirectory }}
{{- if .Values.daemonset.mountPropagation }}
mountPropagation: {{ .Values.daemonset.mountPropagation }}
{{- end }}
{{- if .Values.composer.coreEvents }}
- name: event-volume
mountPath: {{ .Values.daemonset.eventDirectory }}
{{- if .Values.daemonset.mountPropagation }}
mountPropagation: {{ .Values.daemonset.mountPropagation }}
{{- end }}
{{- end }}
{{- if .Values.daemonset.mountContainerRuntimeEndpoint }}
- mountPath: {{ .Values.daemonset.hostContainerRuntimeEndpoint }}
name: container-runtime
Expand Down
1 change: 1 addition & 0 deletions charts/core-dump-handler/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ daemonset:
envFrom: []
sidecarContainers: []
updateStrategy: {}
mountPropagation: ""

serviceAccount:
create: true
Expand Down