Add support for Event Notifications #232
Conversation
& sort lists, where applicable
Plans: Lite, Standard
|
|
||
| func getEnSubscriptionRegistryItem() *schema.RegistryItem { | ||
| return &schema.RegistryItem{ | ||
| Name: "ibm_en_subscription_android", |
There was a problem hiding this comment.
is this supposed to be _android?
There was a problem hiding this comment.
Yeah, the resource is ibm_en_subscription_android, however Go really did not like that files had the word Android in them. It kept saying that it could not find the functions that were in the files named that, so that's why for this one it doesn't quite match
|
|
||
| ibm_en_subscription_sms.subscription_sms_standard_no_usage | ||
| ├─ Outbound IBM Cloud SMS Message Units (Standard plan) Monthly cost depends on usage: $0.01615 per Message Units | ||
| └─ SMS Number Setup Resource Units 1 Resource Units $1.00 |
There was a problem hiding this comment.
i thought these would be noted as a one-time fee?
There was a problem hiding this comment.
Good catch, I forgot to add that note — updated
|
|
||
| var costComponent schema.CostComponent | ||
| component_name := "Push Destination Instances" | ||
| unit := "PUSH_DESTINATION_INSTANCES" |
There was a problem hiding this comment.
it looks like the firefox, huwawei, and chrome, android, iphone, and safari all use the same price and metric (PUSH_DESTINATION_INSTANCES)? it's a lot of redundant code. Would be nice if the code could be reduced for them all to share. not a blocker, but it's a lot of files getting added
There was a problem hiding this comment.
Yeah, I definitely agree... I wasn't sure how to consolidate this, since they are different resources and so they use different schemas.
The following Event Notifications resources are now supported:
ibm_en_destination_androidibm_en_destination_ceibm_en_destination_chromeibm_en_destination_cosibm_en_destination_custom_emailibm_en_destination_custom_smsibm_en_destination_firefoxibm_en_destination_huaweiibm_en_destination_iosibm_en_destination_msteamsibm_en_destination_pagerdutyibm_en_destination_safariibm_en_destination_slackibm_en_destination_snibm_en_destination_webhookibm_en_email_templateibm_en_ibmsourceibm_en_integrationibm_en_integration_cosibm_en_slack_templateibm_en_smtp_configurationibm_en_smtp_settingibm_en_smtp_useribm_en_sourceibm_en_subscription_androidibm_en_subscription_ceibm_en_subscription_chromeibm_en_subscription_cosibm_en_subscription_custom_emailibm_en_subscription_emailibm_en_subscription_firefoxibm_en_subscription_huaweiibm_en_subscription_iosibm_en_subscription_msteamsibm_en_subscription_pagerdutyibm_en_subscription_safariibm_en_subscription_slackibm_en_subscription_smsibm_en_subscription_snibm_en_subscription_webhookibm_en_topicibm_en_webhook_templateNote: There is no support for
ibm_en_subscription_custom_sms, since a quote needs to be provided by IBM over e-mail following a formal request.