Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Security Compliance Center (SCC) #166

Merged
merged 9 commits into from
Apr 24, 2024
Merged

Add support for Security Compliance Center (SCC) #166

merged 9 commits into from
Apr 24, 2024

Conversation

luisarojas
Copy link
Collaborator

@luisarojas luisarojas commented Apr 24, 2024 •
edited
Loading

Added

  • Support for Security Compliance Center (SCC) ibm_resource_instance
    • Cost components for Standard and Trial plans
    • Terraform test configuration, golden test updates
  • Support for Security Compliance Center (SCC) free resources

Changed

  • Fix Watson Assistance variable mentions wa_voice_users → wa_monthly_voice_users

Passing Tests

❯ go test -v ./internal/providers/terraform/ibm/resource_instance_test.go
=== RUN   TestResourceInstance
=== PAUSE TestResourceInstance
=== CONT  TestResourceInstance
=== RUN   TestResourceInstance/HCL
No IBM_CLOUD_IAM_URL credential set, defaults to production.
=== RUN   TestResourceInstance/Terraform_CLI
No IBM_CLOUD_IAM_URL credential set, defaults to production.
--- PASS: TestResourceInstance (23.34s)
    --- PASS: TestResourceInstance/HCL (1.59s)
    --- PASS: TestResourceInstance/Terraform_CLI (21.74s)
PASS
ok      command-line-arguments  24.508s

@luisarojas luisarojas self-assigned this Apr 24, 2024
@luisarojas luisarojas added the enhancement New feature or request label Apr 24, 2024
@luisarojas luisarojas marked this pull request as ready for review April 24, 2024 15:11
@luisarojas luisarojas requested a review from hiltol April 24, 2024 15:11
@hiltol hiltol merged commit 2e9507b into master Apr 24, 2024
6 of 7 checks passed
@hiltol hiltol deleted the feat/scc-support branch April 24, 2024 17:07
luisarojas added a commit that referenced this pull request Apr 27, 2024
@luisarojas
Add support for Security Compliance Center (SCC) (#166)
3e03a47 
* Create new resource_instance file for 'compliance' (SCC) sevice

* Create cost components

* Add example usage units

* Add resource instance variables

* Write TF tests

* Add usage units for tests

* Update test golden file with SCC results

* Fix Watson Assistant usage units variable name

* Add free SCC resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiltol hiltol hiltol approved these changes

Assignees

@luisarojas luisarojas

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luisarojas @hiltol