Skip to content

Conversation

@danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Feb 13, 2025

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR enables binary operations with non-SI units without having to explicitly use the ignore_units argument.

@danielhuppmann danielhuppmann self-assigned this Feb 13, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.8%. Comparing base (ca1bc4c) to head (3c49624).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #907   +/-   ##
=====================================
  Coverage   94.8%   94.8%           
=====================================
  Files         67      67           
  Lines       6355    6410   +55     
=====================================
+ Hits        6025    6080   +55     
  Misses       330     330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danielhuppmann danielhuppmann marked this pull request as ready for review November 12, 2025 08:34
Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a number of refactorings that I'd suggest for _op_data but I guess that is well beyond the scope of this PR.
I've left some comments below for making the tests a little bit easier to read and understand and one small refactoring suggestion for _op_data.
Since none of those affect the functionality of the PR, I'd say it's good to merge either way.

Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @danielhuppmann, good to be merged from my side.

@danielhuppmann danielhuppmann merged commit d5fe4e2 into IAMconsortium:main Nov 13, 2025
17 checks passed
@danielhuppmann danielhuppmann deleted the ops/ops-unit-fastpass branch November 13, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants