-
Notifications
You must be signed in to change notification settings - Fork 125
Add fast route for operations with non-SI units #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fast route for operations with non-SI units #907
Conversation
e9b7087 to
6a758e1
Compare
6a758e1 to
e326b1f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #907 +/- ##
=====================================
Coverage 94.8% 94.8%
=====================================
Files 67 67
Lines 6355 6410 +55
=====================================
+ Hits 6025 6080 +55
Misses 330 330 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
phackstock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a number of refactorings that I'd suggest for _op_data but I guess that is well beyond the scope of this PR.
I've left some comments below for making the tests a little bit easier to read and understand and one small refactoring suggestion for _op_data.
Since none of those affect the functionality of the PR, I'd say it's good to merge either way.
phackstock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @danielhuppmann, good to be merged from my side.
Please confirm that this PR has done the following:
Documentation AddedName of contributors Added to AUTHORS.rstDescription of PR
This PR enables binary operations with non-SI units without having to explicitly use the
ignore_unitsargument.