Update design for js sdk client side #94
Conversation
| <div class="tooltip"> | ||
| <span class="tooltip-trigger">?</span> | ||
| <div class="tooltip-content"> | ||
| The ${IDENTITY_NAME} token used for targeted advertising. This token is passed to advertising partners and automatically refreshed by the SDK in the background. |
There was a problem hiding this comment.
i think its better to just generally say "This token is passed to the bidstream...". also maybe add to the end "...background when expired." so it is clear when/why a token needs refreshing
There was a problem hiding this comment.
Updated the wording/defition for 'Advertising Token' tooltip a bit
|
|
Maybe consider making the generate and clear UID2 buttons navy blue to keep a bit of the same color scheme used in the docs, etc. And then the orange+green stands out more in the sidebar of instructions. Just a thought |
|
web-integrations/google-secure-signals/client-side/html/index.html
Outdated
Show resolved
Hide resolved
| <div class="tooltip"> | ||
| <span class="tooltip-trigger">?</span> | ||
| <div class="tooltip-content"> | ||
| The complete identity object returned by the SDK. Contains the full ${IDENTITY_NAME} identity data including refresh tokens and metadata. Used for debugging and verification. |
There was a problem hiding this comment.
i think it would be good to keep the definitions consistent between multiple sample pages if it is showing the same variable. for example, this definition is different from the identity callback state definition in the above site
| <li>Try entering: <strong>[email protected]</strong></li> | ||
| <li>Table shows "opted out" status</li> | ||
| <li>Click "Clear ${IDENTITY_NAME}" to try another email</li> | ||
| </ul> |
There was a problem hiding this comment.
This "test opt-out" section is different to the section in another site and I think unless it's a differentiator specific to the sites themselves, we should have consistency
There was a problem hiding this comment.
Good catch, the opt out functionality works slightly different for prebid sites (there's not "Has opted out?" section in table) so I updated those instructions to be more accurate. I think it's fine as is but I can also update the tables to be consistent across all pages if we want
Updated design for all client-side websites. For testing, run command
docker compose up -dand view the following sites:(Ignore previous comments below)
Minor notes:
To run from terminal in uid2-examples directoy:
docker compose down && docker compose build --no-cache javascript-sdk-client-side && docker compose up javascript-sdk-client-side -dQuestions: