-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed all the translation in french which were wrong as well as were missing #1395
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the work @SOHAMPAL23 , however, Keeping the shutdown port set to -1 in the Tomcat configuration disables the shutdown port. This can be done for security reasons to prevent unauthorized shutdown commands from being sent to the server. Unless there is a reason behind this change, you can keep it that way.
try running |
@Bahati308 Thanks for the help 👍 |
@@ -19,17 +19,17 @@ | |||
define subcomponents such as "Valves" at this level. | |||
Documentation at /docs/config/server.html | |||
--> | |||
<Server port="-1" shutdown="SHUTDOWN"> | |||
<Listener className="org.apache.catalina.startup.VersionLoggerListener" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you discard these changes?? i think the change is made by docker .
can you add this file to gitignore file so that these docker volume changes arent commited ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @SOHAMPAL23, can you please add this file to gitignore because everytime I have to discard this file which pushing my commits to github.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SOHAMPAL23 you still have these changes here. can you discard them ??
@SOHAMPAL23 did you intentionally add the openelis-docker submodule ?? |
No @mozzy11 I didn't added the file it automatically added in my local file |
👋 Hi, @SOHAMPAL23, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
…missing
Pull Requests Requirements
Fixed all the translations problem in fr.json
I have read and agree to the Contributing Guidelines of this project.
Summary
I have worked on the missing translations part in which some of them needed correction
Related Issue
Fix Missing translation Translations #1252