Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed all the translation in french which were wrong as well as were missing #1395

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

SOHAMPAL23
Copy link

@SOHAMPAL23 SOHAMPAL23 commented Jan 12, 2025

…missing

Pull Requests Requirements

  • Fixed all the translations problem in fr.json

  • I have read and agree to the Contributing Guidelines of this project.

Summary

I have worked on the missing translations part in which some of them needed correction

Related Issue

Fix Missing translation Translations #1252

@SOHAMPAL23 SOHAMPAL23 changed the title Fixed all the translation in french which were wrong as well as were … Fixed all the translation in french which were wrong as well as were missing Jan 12, 2025
Copy link
Contributor

@Bahati308 Bahati308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work @SOHAMPAL23 , however, Keeping the shutdown port set to -1 in the Tomcat configuration disables the shutdown port. This can be done for security reasons to prevent unauthorized shutdown commands from being sent to the server. Unless there is a reason behind this change, you can keep it that way.

@Bahati308
Copy link
Contributor

try running cd frontend/ and then run npm run format for prettier to re-format your changes.

@SOHAMPAL23
Copy link
Author

@Bahati308 Thanks for the help 👍

openelis-docker Outdated Show resolved Hide resolved
@@ -19,17 +19,17 @@
define subcomponents such as "Valves" at this level.
Documentation at /docs/config/server.html
-->
<Server port="-1" shutdown="SHUTDOWN">
<Listener className="org.apache.catalina.startup.VersionLoggerListener" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you discard these changes?? i think the change is made by docker .
can you add this file to gitignore file so that these docker volume changes arent commited ??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @SOHAMPAL23, can you please add this file to gitignore because everytime I have to discard this file which pushing my commits to github.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SOHAMPAL23 you still have these changes here. can you discard them ??

@mozzy11
Copy link
Collaborator

mozzy11 commented Jan 16, 2025

@SOHAMPAL23 did you intentionally add the openelis-docker submodule ??

@SOHAMPAL23
Copy link
Author

No @mozzy11 I didn't added the file it automatically added in my local file

@github-actions github-actions bot added the merge conflict Merge Conflicts label Jan 17, 2025
Copy link

👋 Hi, @SOHAMPAL23,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict Merge Conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants