added more test for patientService and patientTypeService #1301
Conversation
| @@ -97,413 +84,6 @@ public void getData_shouldCopyPropertiesFromDatabase() throws Exception { | |||
| Assert.assertEquals(gender, savedPatient.getGender()); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
@josephbate , why did you have to delete the existing tests ??
There was a problem hiding this comment.
my local repository got corrupted and i didn't noticed it till when i pushed it
but i have restored it
There was a problem hiding this comment.
sorry was on a different branch
There was a problem hiding this comment.
you never got rid of the chanes here
|
did you run the |
yes i did |
|
i was on the different branch |
|
|
||
| Assert.assertEquals(gender, savedPatient.getGender()); | ||
| } | ||
|
|
There was a problem hiding this comment.
can you then just discard all changes in this file ??
| @@ -224,8 +224,7 @@ public PatientType readPatientType(String idString) { | |||
| public List<PatientType> getPatientTypes(String description) throws LIMSRuntimeException { | |||
| List<PatientType> list = new Vector<>(); | |||
| try { | |||
| String sql = "from patientType l where upper(l.description) like upper(:param) order by" | |||
| + " upper(l.description)"; | |||
There was a problem hiding this comment.
also disacrd tis formating change here
There was a problem hiding this comment.
i dont know what exactly you want me to do coz that was a chenge i made in the dao so that it can filter the patienttypes by string it cause before that it wascreating an error
do you want me to revert the changes? @mozzy11
|
hello @mozzy11 fixed the format issue |
Pull Requests Requirements
Issue number if applicable.
documentation.
Summary
PatientTypeDAOImp.getPatientType()to correctly filter PatientTypes by key stringCc. @mozzy11
Screenshots
[Add relevant screenshots here if applicable]
Related Issue
[Add a link to the related issue or mention it here if applicable]
Other
[Add any additional information or notes here]