Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added more test for patientService and patientTypeService #1301

Merged
merged 12 commits into from
Dec 16, 2024

Conversation

josephbate
Copy link
Contributor

@josephbate josephbate commented Nov 6, 2024

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

  • added more patientSercvice Tests
  • Created PatientTypeServiceTest class
  • edited the PatientTypeDAOImp.getPatientType() to correctly filter PatientTypes by key string
    Cc. @mozzy11

Screenshots

[Add relevant screenshots here if applicable]

Related Issue

[Add a link to the related issue or mention it here if applicable]

Other

[Add any additional information or notes here]

@mozzy11
Copy link
Collaborator

mozzy11 commented Nov 6, 2024

did you run the formatter ??

@josephbate
Copy link
Contributor Author

josephbate commented Nov 6, 2024

did you run the formatter ??

yes i did

@josephbate
Copy link
Contributor Author

i was on the different branch

@josephbate
Copy link
Contributor Author

hello @mozzy11 fixed the format issue

@mozzy11 mozzy11 merged commit 8a5586d into I-TECH-UW:develop Dec 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants