55 - Include an existing image into an existing collection #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benel
requested changes
Jun 6, 2023
|
@StachoB @Ziwei-GONG-UTT @lililiane @LIUC2H5OH @ShengjieZhou |
…pertopic#55) Co-authored-by: ShengjieZhou <[email protected]> Co-authored-by: Liliane <[email protected]>
…rtopic#55) Co-authored-by: ShengjieZhou <[email protected]> Co-authored-by: Liliane <[email protected]>
…ypertopic#55) Co-authored-by: Barbara <[email protected]>
benel
requested changes
Jan 9, 2024
| @@ -0,0 +1,5 @@ | |||
| function (doc) { | |||
| if ( doc.links.filter(e => e.verb === 'includes').length > 0 ){ | |||
There was a problem hiding this comment.
You may use Array.prototype.some() instead.
| @@ -0,0 +1,5 @@ | |||
| function (doc) { | |||
| if ( doc.links.filter(e => e.verb === 'includes').length > 0 ){ | |||
| emit(doc.dc_title, doc); | |||
There was a problem hiding this comment.
Never emit the whole document as a value. Use include_docs at query time instead.
|
Please note that my comments are just here for future reference. They don't need any action from you. |
benel
changed the title
6 tasks
|
Implemented by 884af33. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We, @StachoB @Ziwei-GONG-UTT @lililiane @LIUC2H5OH @ShengjieZhou , hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.
Related Ticket #55