Provide request.original object to afterSave hook as per real Parse Server behaviour#92
Open
darrenkidd wants to merge 4 commits intoHustle:masterfrom
Open
Provide request.original object to afterSave hook as per real Parse Server behaviour#92darrenkidd wants to merge 4 commits intoHustle:masterfrom
darrenkidd wants to merge 4 commits intoHustle:masterfrom
Conversation
Rather than have beforeSave do a manual look up of the object in the collection, this approach leaves all of that to handlePutRequest, which is the only method that deals in updates (vs creates).
darrenkidd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my proposed fix for #91.
Happy to remove some of the extra test scripts and documentation; wanted them there to start with so I couldn't lose them and so others could see the full source.
All tests were passing when I pushed.
EDIT: motivation for this is that I have an
afterSavehook that relies on identifying when a particular value has been incremented. Without this fix it's impossible for me to unit test that behaviour, so thought I'd give it a go.