feat: FIT-750: Update Agreement Selected UI #8575
Conversation
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8575 +/- ##
===========================================
- Coverage 67.42% 67.41% -0.02%
===========================================
Files 783 783
Lines 60020 60021 +1
Branches 10161 10161
===========================================
- Hits 40468 40461 -7
- Misses 19549 19557 +8
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| new_data['agreement_selected'] = { | ||
| 'annotators': {'all': True, 'ids': []}, | ||
| 'models': {'all': True, 'ids': []}, | ||
| 'ground_truth': False | ||
| } |
There was a problem hiding this comment.
We don't care for existing configurations right? This isn't fully released yet, so I think its okay
There was a problem hiding this comment.
it was enabled for everyone for a few days - we had to turn it off after a few days - so the migration is needed
There was a problem hiding this comment.
It was left on for some people, so it definitely will need to migrate from old to new.
There was a problem hiding this comment.
@hakan458 can we check how many people have it configured? I feel that its okay to reset it them for them, but not certain.
4 participants
This pull request improves the handling of the Agreement filter dropdown in the data manager table. The main focus is to ensure that the dropdown closes automatically after saving changes and to provide a way for the header cell to trigger closing the dropdown.
Dropdown behavior improvements:
onClosecallback toAgreementSelected.HeaderCell, allowing the header cell to close the dropdown when needed. [1] [2]onSavehandler inTableHead.jsxto automatically close the dropdown after saving agreement filters.