Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-1191: Fix drawing tools scenarios with ctrl pressed #6056

Merged
merged 10 commits into from
Jul 25, 2024

Conversation

Gondragos
Copy link
Collaborator

@Gondragos Gondragos commented Jul 3, 2024

This fix changes behaviour into:

  1. We can draw region over another region with keeping ctrl/cmd pressed only when there is no selected region yet.
  2. We can add region to selection with ctrl/cmd pressed, in case if there is(are) some selected region(s).

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

There is an intersection of two expected behaviours:

  1. We need to draw regions over other regions. And that was originally solved with adding ability to draw with pressed ctrl/cmd key to ignore interactions with existing regions.
  2. We want to be able to select more than one region to work with all them at once (hiding, deleting, moving and so on). And we use ctrl/cmd pressing as well.

So that, with keeping ctrl/cmd pressed and clicking on the region we got:

  1. Starting drawing region by clicking.
  2. Adding region to the current selection.
    But all that in the same time.

What feature flags were used to cover this change?

N/A

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Image, Drawing tools

@github-actions github-actions bot added the fix label Jul 3, 2024
Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 2048a06
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66a2b98967850e0008df2ff4

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 2048a06
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66a2b989b6812600089e346d

Copy link
Contributor

@bmartel bmartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🔥

@yyassi-heartex
Copy link
Contributor

yyassi-heartex commented Jul 11, 2024

/selenium test

'/selenium' is an unknown pull-request command.
See '/help'

@Gondragos
Copy link
Collaborator Author

Gondragos commented Jul 15, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/editor/src/components/TopBar/tests/CurrentTask.test.tsx

@Gondragos
Copy link
Collaborator Author

Gondragos commented Jul 16, 2024

/git merge develop

Workflow run
Successfully merged: Already up to date.

@hlomzik
Copy link
Collaborator

hlomzik commented Jul 17, 2024

/git merge develop

Workflow run
Successfully merged: 10 files changed, 19 insertions(+), 18 deletions(-)

@Gondragos
Copy link
Collaborator Author

Gondragos commented Jul 22, 2024

/git merge develop

Workflow run
Successfully merged: 14 files changed, 80 insertions(+), 55 deletions(-)

@triklozoid
Copy link
Contributor

triklozoid commented Jul 23, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/datamanager/src/utils/tests/helpers.test.ts

@Gondragos
Copy link
Collaborator Author

Gondragos commented Jul 25, 2024

/git merge develop

Workflow run
Successfully merged: create mode 100644 label_studio/data_manager/migrations/0011_auto_20240718_1355.py

@Gondragos Gondragos enabled auto-merge (squash) July 25, 2024 21:10
@Gondragos Gondragos merged commit 0d980a2 into develop Jul 25, 2024
31 checks passed
@Gondragos Gondragos deleted the fb-leap-1191/image-ctrl-click branch July 25, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants