Fix Cabinet saving cards through restarts

[ElliotHume]

Quick fix here & One more config addition

Fix:

It's all in the comments but ItemStack.save doesn't mutate the tag it is given. so has to be inside the brackets so it works properly. This worked in 1.0.4 (current release build) but got broken with the changes to the binder data saving for 1.0.5.
Added some debugging just in case.

Also Claude (I am using AI code reviews, can redo without if you object) found the getUpdateTag() optimization, I tested in singleplayer and it seems fine to me.

Addition:

The master tier binder could be equipped as a curio and provided stats for all 10k pages of cards despite only costing glass to make instead of the netherite binder. I added a config to disable the stats from it. I think its better as config instead of force disabled bc a modpack maker could make an endgame recipe for the master tier if they did want it to be a pinnacle stat item.

[Howlite-UI]

Hi @ElliotHume,

Thanks again for your work! I’ve cherry-picked the fix for the CardCabinet directly into main since it solved the issue perfectly.

I decided to leave out the master binder changes for now, as I want to keep its design purely as a collection album rather than having stats tied to it.

Thanks again for the contribution!

[ElliotHume]

No problem @Howlite-UI,

I think there's a misunderstanding tho, in your current code the master binder DOES provide stats, even though it should just be a collector item. My changes add the config option to make it so that it does NOT provide stats. Without the changes you can equip a master binder with near infinite stats.

Try it for yourself! The NeoForgeMasterAlbumItem.java has a getDynamicModifiers that provides stats, despite being meant for collecting only.

I'm down to just straight up remove that though, I only added the config toggle because I wasn't sure if you had done this originally on purpose. Which it sounds like you havent, so it might be cleaner to fully delete that. But a config option doesn't hurt either