fix: enforce active account lifecycle - #47
Merged
Conversation
HoungDev
marked this pull request as ready for review
August 11, 2026 13:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
User.is_activeexisted in the data model, and some MFA/OIDC paths checked it, but password login, current-user resolution, and refresh rotation did not enforce it consistently. The admin API also had no supported operation for changing account status and revoking sessions together.Security behavior
account_disabledreasonRegression fix
The first CI run exposed that
SessionLocal(autoflush=False)combined withpopulate_existing()could discard an accepted MFA counter before commit. Session issuance now explicitly flushes pending security state before reloading the locked user, and a focused regression test protects that ordering.Validation
GitHub Actions CI run #99 passed:
Local validation also passed 16 focused unit/rollback tests, package build, OpenAPI smoke, and diff checks.