Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] - Network interceptor #6

Merged
merged 3 commits into from
May 23, 2023
Merged

[Feature] - Network interceptor #6

merged 3 commits into from
May 23, 2023

Conversation

juanR-hk
Copy link
Collaborator

@juanR-hk juanR-hk commented May 19, 2023 •
edited
Loading

Overview

  • New flag added to allow the user intercept requests and responses through URLProtocol and URLSessionDataDelegate`.
  • New variable exposes which contains the URLSessionConfiguration ready to be used in the networking layer

Pull Request checker

Make sure you've checked all the following items.

  • You've assigned the PR to yourself
  • You've requested at least two reviewers
  • You've set the correct labels (bugfix, enhancement, feature, etc.)
  • You've manually run all tests (if there are any)

@juanR-hk juanR-hk added the feature New feature or request label May 19, 2023
@juanR-hk juanR-hk self-assigned this May 19, 2023
@juanR-hk juanR-hk changed the title Network interceptor [Feature] - Network interceptor May 19, 2023
martinlago
martinlago requested changes May 23, 2023
View reviewed changes
Copy link
Collaborator

@martinlago martinlago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I only left a typo comment.

Sources/HKLogger/HKLogger.swift Outdated Show resolved Hide resolved
@juanR-hk juanR-hk requested a review from martinlago May 23, 2023 21:26
@blorenzo10 blorenzo10 merged commit cba80e5 into main May 23, 2023
@blorenzo10 blorenzo10 deleted the networkInterceptor branch May 23, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blorenzo10 blorenzo10 blorenzo10 approved these changes

@martinlago martinlago martinlago approved these changes

Assignees

@juanR-hk juanR-hk

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juanR-hk @blorenzo10 @martinlago