Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix watchFiles error with vite 5.3 #1312

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

SeppahBaws
Copy link
Collaborator

Fixes #1306

Since the addWatchFile is context-aware, it ended up being invalid by the time the houdini plugins came around to use the function.
This PR is a quick fix to ensure that people can keep using Houdini with the latest version of Vite.
We'll need to properly rewrite the Vite plugin at one point so that this.addWatchFile is only called from within the houdini vite plugin itself.

For more context, take a look at the referenced issue, or this thread in Discord

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

Copy link

changeset-bot bot commented Jul 2, 2024

🦋 Changeset detected

Latest commit: 8978afd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
houdini Patch
houdini-adapter-auto Patch
houdini-adapter-cloudflare Patch
houdini-adapter-node Patch
houdini-react Patch
houdini-svelte Patch
houdini-plugin-svelte-global-stores Patch
create-houdini Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit 8978afd
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/668404752359ff0008f7252a

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for houdini-docs-next canceled.

Name Link
🔨 Latest commit 8978afd
🔍 Latest deploy log https://app.netlify.com/sites/houdini-docs-next/deploys/66840475d960ed0008effea5

@SeppahBaws SeppahBaws enabled auto-merge (squash) July 2, 2024 13:47
@SeppahBaws SeppahBaws merged commit e21f7c6 into main Jul 2, 2024
14 checks passed
@SeppahBaws SeppahBaws deleted the bind-vite-addwatchfile branch July 2, 2024 15:43
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
@macmillen
Copy link
Contributor

Awesome, thanks for fixing it! When will it be released?

@SeppahBaws
Copy link
Collaborator Author

Hopefully by the end of this week, I'm just bumping some versions in the repository, and I want it to be part to the next version as well.

@SeppahBaws
Copy link
Collaborator Author

SeppahBaws commented Jul 5, 2024

@macmillen and others: I just published the fix, it's up on v1.2.48

I wasn't able to bump the dependencies yet, as I'm getting some very strange errors when building. But the package is forwards compatible so everything should just work.

@macmillen
Copy link
Contributor

Thank you! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't work with vite 5.3
3 participants