Refactor critic networks using the new encoding network #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed a copy of EncodingNetwork.make_parallel(), where the copy is not correctly implemented.
alf/networks/critic_networks_test.py
Outdated
| @@ -49,7 +50,7 @@ def _init(self, lstm_hidden_size): | |||
| return network_ctor, state | |||
|
|
|||
| @parameterized.parameters((100, ), (None, ), ((200, 100), )) | |||
| def test_critic(self, lstm_hidden_size): | |||
| def test_critic(self, lstm_hidden_size=(200, 100)): | |||
There was a problem hiding this comment.
can remove =(200, 100)
Haichao-Zhang
approved these changes
Aug 30, 2021
pd-perry
pushed a commit
to pd-perry/alf
that referenced
this pull request
Dec 11, 2021
…ics#993) * Refactor critic networks using the new encoding network Also fixed a copy of EncodingNetwork.make_parallel(), where the copy is not correctly implemented. * Address comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed EncodingNetwork.make_parallel(), where the copy() is not correctly implemented.