C++ const enforcing #221
Open
C++ const enforcing #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the C <ABC.h> format to the C++ <cABC>
changing typedefs to usings for increased readability
Error prone code let to one input
Proper C++ standard header name
C style to C++ style
Removed human redundancy
Put const wherever it can be useful without touching the function signatures Also folded T v; v = u; to T v = u;
typedefs become usings for loop now in range mode
|
How nice the SFML dependency can't build |
|
I don't think it's a good idea to still add new dependencies. Is it possible without them? if not, I'll see if I can add them to Travis. |
|
It's actually not a dependency we added ourselves, it's the last master version of SFML that requires it |
|
Hmm. Okay. |
|
If it's SFML then it could be possible to include it in our repository so it's not a system requirement but just included in the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Night session of const enforcing and changing C includes to C++ ones