[FEAT] naver maps api #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinjoo-lab
force-pushed
the
feat/naver-maps-api
branch
from
9c0dcd8
to
6ae7dc0
Compare
ohksj77
reviewed
Aug 29, 2023
| package com.twtw.backend.global.client; | ||
|
|
||
| public interface PathClient<T, R> { | ||
| public String request(T request); |
There was a problem hiding this comment.
나는 R을 return 값으로 쓰려고 넣었던 거고 여기서는 R이 안쓰이는 것 같아..!
There was a problem hiding this comment.
저게 일단 String으로 반환하는건데 나중에는 R로 바꿔야 해서
임시로 해놓은거야 저게 경로 반환값 정리를 아직 안해서 이제 R로 바꿔야함
| public class SearchPathResponse { | ||
| int code; | ||
| String message; | ||
| String currentDateTime; |
|
|
||
| String carType; | ||
|
|
||
| @Enumerated(value = EnumType.STRING) |
There was a problem hiding this comment.
이 어노테이션은 필요 없을 것 같구 private 붙여줘!
| } | ||
|
|
||
| /*response 변경*/ | ||
| @PostMapping("/search/path") |
There was a problem hiding this comment.
이거 약간 단어가 중복되는 느낌이 들어!
/paths/search/path 가 되니까..!
There was a problem hiding this comment.
그럼 그냥 search까지만 할게 중복이 되긴하니까
| @@ -15,7 +15,7 @@ | |||
| import org.springframework.security.web.authentication.UsernamePasswordAuthenticationFilter; | |||
|
|
|||
| @Configuration | |||
| @EnableWebSecurity | |||
| @EnableWebSecurity(debug = true) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
추가/수정한 기능 설명
kakao 경로 API 문제점 : 경로에 대한 정보를 json으로 제공하지 않음 -> url 호출로 카카오 맵을 통해 확인 가능(별도로 카카오맵을 열어야 함)
naver maps api의 문제점 : 좌표에 대한 정보 제공이 부족 but 경로 제공 api가 json으로 제공
결론
기본적인 좌표에 대한 정보 제공 (목적지 , 주변 정보) - kakao api
경로 - naver api
추가
경로 제공을 naver maps api 사용
https://api.ncloud-docs.com/docs/ai-naver-mapsdirections-driving#RequestPositionFormat
webClient의 분리
특이사항
테스트까지는 진행하지 않음 (기본적인 연동에 집중한 첫 번째 커밋)
check list