go 1.15.6 #66355

shigemk2 · 2020-12-06T17:09:17Z

Created with brew bump-formula-pr.

resource blocks may require updates.

fxcoudert · 2020-12-07T11:12:20Z

On 10.14:

brew install --build-from-source buildkit
brew install --build-from-source cig
brew test --retry --verbose glab
brew test --retry --verbose glab
brew install --build-from-source grv
brew install --build-from-source hasura-cli
brew install --build-from-source octant
brew install --build-from-source the_platinum_searcher

carlocab · 2020-12-08T16:02:40Z

10.15:

Error: 7 failed steps!
brew install --build-from-source buildkit
brew install --build-from-source cig
brew test --retry --verbose glab
brew test --retry --verbose glab
brew install --build-from-source hasura-cli
brew install --build-from-source octant
brew install --build-from-source the_platinum_searcher

11.0:

Error: 11 failed steps!
brew install --build-from-source buildkit
brew install --build-from-source cig
brew install --build-from-source dlite
brew install --build-from-source docker-machine-driver-xhyve
brew test --retry --verbose glab
brew test --retry --verbose glab
brew install --build-from-source hasura-cli
brew install --build-from-source noti
brew install --build-from-source nsq
brew install --build-from-source octant
brew install --build-from-source the_platinum_searcher

carlocab · 2020-12-08T16:12:42Z

==> brew install --build-from-source the_platinum_searcher
==> FAILED
==> Downloading https://github.com/monochromegane/the_platinum_searcher/archive/v2.2.0.tar.gz
==> Downloading from https://codeload.github.com/monochromegane/the_platinum_searcher/tar.gz/v2.2.0
==> godep restore
Last 150 lines from /Users/brew/actions-runner/_work/homebrew-core/homebrew-core/bottles/logs/the_platinum_searcher/01.godep:
2020-12-07 11:56:53 +0000

godep
restore

godep: Dep (github.com/BurntSushi/toml) restored, but was unable to load it with error:
	Package (bufio) not found
godep: Dep (github.com/jessevdk/go-flags) restored, but was unable to load it with error:
	Package (bufio) not found
godep: Dep (github.com/monochromegane/conflag) restored, but was unable to load it with error:
	Package (encoding/json) not found
godep: Dep (github.com/monochromegane/go-gitignore) restored, but was unable to load it with error:
	Package (bufio) not found
godep: Dep (github.com/monochromegane/go-home) restored, but was unable to load it with error:
	Package (os) not found
godep: Dep (github.com/monochromegane/terminal) restored, but was unable to load it with error:
	Package (runtime/cgo) not found
godep: Dep (github.com/shiena/ansicolor) restored, but was unable to load it with error:
	Package (bytes) not found
godep: Dep (golang.org/x/text/encoding) restored, but was unable to load it with error:
	Package (errors) not found
godep: Dep (golang.org/x/text/encoding/internal) restored, but was unable to load it with error:
	Package (errors) not found
godep: Dep (golang.org/x/text/encoding/japanese) restored, but was unable to load it with error:
	Package (unicode/utf8) not found
godep: Dep (golang.org/x/text/transform) restored, but was unable to load it with error:
	Package (bytes) not found
godep: Dep (gopkg.in/yaml.v2) restored, but was unable to load it with error:
	Package (bytes) not found
godep: Error checking some deps.

bufio, os, bytes, etc are meant to be part of go's stdlib, so their being missing is a problem.

shigemk2 · 2020-12-09T06:17:29Z

There will be a lot of errors in other packages depending on go when updating this formula.
So how should I deal with this formula?

carlocab · 2020-12-09T15:59:55Z

Not really familiar with go, so this is a total shot in the dark, but: the fact that parts of the stdlib appear to be missing makes me suspect that the gobootstrap resource needs updating, as the existing one may be too old to build the latest version of go.

Would be nice if we can find documentation to support this.

carlocab · 2020-12-09T17:01:23Z

More godep errors:

==> brew install --build-from-source cig
==> FAILED
==> Downloading https://github.com/stevenjack/cig/archive/v0.1.5.tar.gz
==> Downloading from https://codeload.github.com/stevenjack/cig/tar.gz/v0.1.5
==> godep restore
Last 150 lines from /Users/brew/actions-runner/_work/homebrew-core/homebrew-core/bottles/logs/cig/01.godep:
2020-12-06 20:28:56 +0000

godep
restore

Warning: ARNING]: godep should only be used inside a valid go package directory and
Warning: ARNING]: may not function correctly. You are probably outside of your $GOPATH.
Warning: ARNING]:	Current Directory: /private/tmp/cig-20201206-85970-1n3dkx3/cig-0.1.5
Warning: ARNING]:	$GOPATH: /private/tmp/cig-20201206-85970-1n3dkx3/cig-0.1.5
godep: WARNING: Godep workspaces (./Godeps/_workspace) are deprecated and support for them will be removed when go1.8 is released.
godep: WARNING: Go version (go1.15) & $GO15VENDOREXPERIMENT= wants to enable the vendor experiment, but disabling because a Godep workspace (Godeps/_workspace) exists
godep: Dep (github.com/codegangsta/cli) restored, but was unable to load it with error:
	Package (errors) not found
godep: Dep (github.com/fatih/color) restored, but was unable to load it with error:
	Package (fmt) not found
godep: Dep (github.com/mitchellh/go-homedir) restored, but was unable to load it with error:
1106
	Package (bytes) not found
godep: Dep (github.com/shiena/ansicolor) restored, but was unable to load it with error:
	Package (bytes) not found
godep: Dep (gopkg.in/yaml.v2) restored, but was unable to load it with error:
	Package (bytes) not found
godep: Error checking some deps.

Reading about it a bit more, it seems GOPATH needs to be set correctly?

This one looks like an upstream issue:

==> brew install --build-from-source dlite
==> FAILED
==> Downloading https://github.com/nlf/dlite/archive/1.1.5.tar.gz
==> Downloading from https://codeload.github.com/nlf/dlite/tar.gz/1.1.5
==> make dlite
Last 150 lines from /Users/brew/actions-runner/_work/homebrew-core/homebrew-core/bottles/logs/dlite/01.make:
2020-12-06 21:54:01 +0000

make
dlite

GO15VENDOREXPERIMENT=1 go build
# github.com/nlf/dlite/vendor/github.com/TheNewNormal/libxhyve
block_if.c:125:1: error: static declaration of 'preadv' follows non-static declaration
In file included from block_if.c:49:
In file included from vendor/github.com/TheNewNormal/libxhyve/include/xhyve/block_if.h:38:
/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk/usr/include/sys/uio.h:103:9: note: previous declaration is here
block_if.c:135:1: error: static declaration of 'pwritev' follows non-static declaration
In file included from block_if.c:49:
In file included from vendor/github.com/TheNewNormal/libxhyve/include/xhyve/block_if.h:38:
/Library/Developer/CommandLineTools/SDKs/MacOSX11.0.sdk/usr/include/sys/uio.h:104:9: note: previous declaration is here
make: *** [dlite] Error 2

glab just looks like it has a broken test:

==> /usr/local/Cellar/glab/1.12.1/bin/glab issue list --all
Error: glab: failed
An exception occurred within a child process:
  Test::Unit::AssertionFailedError: </This\ is\ a\ test\ issue/> was expected to be =~
<"No issues match your search in profclems/test\n" + "\n" + "\n">.

SMillerDev · 2020-12-09T17:46:35Z

Godep has been deprecated for a while already. I think it's time for it to be removed

carlocab · 2020-12-09T18:13:43Z

Ok. I don't really know how to do that though. I'll try to have a look.

Groxx · 2020-12-10T03:29:49Z

Hmm. For dlite in particular: https://github.com/Homebrew/homebrew-core/blob/master/Formula/dlite.rb -> https://github.com/nlf/dlite/tree/1.1.5 -> dlite is 5 years old, and using a long-deprecated build tool. It's sorta surprising it works at all.

(Godep hasn't had an update since January 2018: https://github.com/tools/godep, and the repo is archived. It's as dead as can be.)

SMillerDev · 2020-12-10T08:45:30Z

Ok. I don't really know how to do that though. I'll try to have a look.

git rm Formula/godep.rb

carlocab · 2020-12-10T08:50:21Z

I was hoping not to leave a pile of broken formulae in its wake, but I suppose that works too.

Loyalsoldier · 2020-12-11T17:06:01Z

Any update?

carlocab · 2020-12-11T17:17:18Z

Doesn't look like it. We could use your help fixing the build failures, however. It would help this PR proceed.

SMillerDev · 2020-12-11T17:17:48Z

As you can see, no.

Loyalsoldier · 2020-12-11T18:01:31Z

If to remove godep, all formulas that depend on godep should also be removed. Right?

mikesep · 2020-12-11T18:16:06Z

For what it's worth, I think the issue with the godep builds happens when using a godep built with a different version of go than the one currently building the program.

Testing on macOS 10.15.7, I get godep poured from a bottle by default. godep version says godep v80 (darwin/amd64/go1.15.4), but I have go version go1.15.5 darwin/amd64. With that setup, I can reproduce the godep build errors for cig and the_platinum_searcher. If I reinstall godep with --build-from-source, I get godep v80 (darwin/amd64/go1.15.5), which matches my go version, and the builds for cig and the_platinum_searcher now succeed.

carlocab · 2020-12-11T18:20:58Z

Thanks, @mikesep. That sounds promising.

@shigemk2, care to add a revision bump commit for godep to this PR? (Sorry @SMillerDev. We can dig that grave for godep when this PR is done?)

carlocab · 2020-12-11T18:27:23Z

Actually, maybe burning godep won't be so bad. At worst we'd only have to get rid of two other formulae:

❯ brew uses --include-build --include-test --recursive godep
cig                                                               the_platinum_searcher

mikesep · 2020-12-11T18:36:49Z

The buildkit failure seems to be due to v0.8.0 potentially being retagged. The formula bump in #66110 seems to be just after the buildkit commit in that PR (d5f179b) and just before the commit that v0.8.0 now points to (73fe473).

Loyalsoldier · 2020-12-11T18:43:51Z

Actually, maybe burning godep won't be so bad. At worst we'd only have to get rid of two other formulae:
❯ brew uses --include-build --include-test --recursive godep
cig                                                               the_platinum_searcher

Just file two PRs to these two repos to remove godep and support go module.

stevenjack/cig#44

monochromegane/the_platinum_searcher#211

carlocab · 2020-12-11T21:36:33Z

This should hopefully fix buildkit: #66750

carlocab · 2020-12-12T14:51:56Z

This is going to fail CI as cig and the_platinum_searcher still depend on godep.

Either those two formulae are also removed, or fixed so that they no longer depend on godep. But we may need to wait for @Loyalsoldier's PRs to be merged for that.

I suggest giving godep a revision bump in the meantime to fix the build failure without having to remove two maintained (I think?) formulae in the process.

I think we also deprecate then disable formula before removing them (unless they should never have been in homebrew-core in the first place). Update: Ah, godep has already been deprecated. I guess disable then.

SMillerDev · 2020-12-12T14:53:16Z

Either those two formulae are also removed, or fixed so that they no longer depend on godep. But we may need to wait for @Loyalsoldier's PRs to be merged for that.

I think the best way is to make a separate PR applying the patch from the upstream pull requests to the formula.

carlocab · 2020-12-12T14:53:45Z

Cool. Let me give those a try.

shigemk2 · 2020-12-12T15:32:50Z

Sorry for bothering you.
So all I have to do is waiting that these cool PRs will be merged.
stevenjack/cig#44
monochromegane/the_platinum_searcher#211

carlocab · 2020-12-12T15:34:53Z

Ok. I've fixed cig and pt. PR ~~will be up shortly~~ here: #66808.

carlocab · 2020-12-18T08:09:35Z

These are the errors from the two fn testruns:

==> /usr/local/Cellar/fn/0.6.1/bin/fn create app myapp

Fn: read tcp [::1]:56414->[::1]:56411: read: connection reset by peer

==> /usr/local/Cellar/fn/0.6.1/bin/fn create app myapp

Fn: Post "http://localhost:56415/v2/apps": net/http: HTTP/1.x transport connection broken: unexpected EOF

I suspect the ports that fn is trying to access during the test are meant to be unused, but they happen to be in use during this particular CI run. This might be just like the [email protected] CI issues (cf. #66727, #66450).

I think this just leaves the frugal error unexplained.

carlocab · 2020-12-18T08:24:18Z

CI failure summary

Formula	CI Error	Node	Comment
frugal	`install -s`	10.14	❓
glab	`test`	10.14,10.15	missing gitlab issue, #66355 (comment), fix at https://gitlab.com/profclems/test/-/issues/1
grv	`install -s`	10.14	known failure: rgburke/grv#107
hasura-cli	`install -s`	10.14,10.15,11.0	sha256 mismatch, #67065
pumba	`install -s`	10.14,10.15,11.0	sha256 mismatch, #67073
fn	`test`	10.15	CI problem? #66355 (comment), #66355 (comment)
dlite	`install -s`	11.0	#67054
docker-machine-driver-xhyve	`install -s`	11.0	#67155

carlocab · 2020-12-18T09:16:58Z

Looks like whatever PRs I linked to in my last comment have all been merged. Perhaps this PR should be rebased on master and re-run?

fxcoudert · 2020-12-18T09:53:13Z

Rebased

andig · 2020-12-18T09:54:39Z

Frugal builds from source on 1.15.5. ~~A rebase would be great.~~

carlocab · 2020-12-18T11:11:34Z

The fn and frugal errors didn't show up in the first round of tests actually: #66355 (comment), #66355 (comment)

This further suggests that those were just CI hiccups. If there are no new errors then this may well be good to merge. In theory there should, I think, just be one error: grv on 10.14.

andig · 2020-12-18T11:28:11Z

grv's last commit is 2 years old, no issue answers since 2019. Shall we deprecate/disable it as well while we're at it to prevent it from popping up again?

carlocab · 2020-12-18T11:40:14Z

grv still works on the two newer versions of macOS and hasn't been replaced by something else, so I don't think that's necessary just yet.

Even if it's disabled now that won't change anything about the test currently running.

fxcoudert · 2020-12-18T11:43:48Z

I think we can merge in the current state of things, once CI has run through

arbourd · 2020-12-18T13:38:56Z

Thank you all. ❤️

chenrui333 · 2020-12-18T16:51:30Z

yeah, I agree!! We can totally fix the individual formula one by one. Right now, go formula update takes much longer time to run.

arbourd · 2020-12-19T04:06:08Z

New sha mismatch from teleport 😅

carlocab · 2020-12-19T04:23:22Z

Upstream issue filed: gravitational/teleport#5174

PR to update here: #67231

carlocab · 2020-12-19T04:41:04Z

~~The teleport sha256 changed again since my PR.~~

No, I was just looking at the wrong tarball 😅

However, it seems both their v5.0.1 and v5.0.2 tarballs had a change in sha256.

carlocab · 2020-12-19T07:39:12Z

There's a new error on 10.15:

Error: 2 failed steps!
brew install --build-from-source ironcli
brew install --build-from-source teleport

fatal: index-pack failed
4153
: command failed: [git clone --recursive -v --progress https://go.googlesource.com/sys /private/tmp/ironcli-20201218-92144-wrhosj/ironcli-0.1.6/pkg/dep/sources/https---go.googlesource.com-sys]: exit status 128

However, this just appears to be a transient network failure. I don't think it should block this PR.

Loyalsoldier · 2020-12-19T07:51:20Z

It seems GitHub Actions macOS virtual environment encountered network issues these several days.
actions/runner-images#2247 (comment)

carlocab · 2020-12-19T07:59:31Z

It's not clear that's related, as Homebrew do not use GitHub runners but instead host their own. On the other hand, it is also possible that the same issues affect self-hosted runners.

carlocab · 2020-12-19T15:16:52Z

11.0:

Error: 19 failed steps!
brew install --build-from-source octant
brew install --build-from-source okteto
brew install okteto
brew install --build-from-source opa
brew install --build-from-source openshift-cli
brew install openshift-cli
brew install --build-from-source operator-sdk
brew install operator-sdk
brew install --build-from-source ory-hydra
brew install ory-hydra
brew install --build-from-source osm
brew install osm
brew install --build-from-source overmind
brew install --build-from-source packer
brew install packer
brew install --build-from-source packetbeat
brew install packetbeat
brew install --build-from-source pdfcpu
brew install --build-from-source teleport

I'll take a closer look at the CI logs shortly.

fxcoudert · 2020-12-19T15:30:07Z

A lot of those 11.0 build-from-source failures were “no space left on device”. I am going to merge.

carlocab · 2020-12-19T15:31:40Z

I thought it was something like that too but hadn't had a chance to look at them closely yet. Glad we could get this done!

fxcoudert · 2020-12-19T15:39:22Z

Thanks to everyone who helped with this PR!

chenrui333 mentioned this pull request Dec 6, 2020

go 1.15.6 #66331

Closed

5 tasks

Loyalsoldier mentioned this pull request Dec 11, 2020

Comply with semantic import versioning monochromegane/the_platinum_searcher#211

Closed

Loyalsoldier mentioned this pull request Dec 11, 2020

Comply with Golang semantic import versioning stevenjack/cig#44

Closed

shigemk2 force-pushed the bump-go-1.15.6 branch from 24d2ccf to aa4f8ea Compare December 12, 2020 15:07

andig mentioned this pull request Dec 18, 2020

docker-machine-driver-xhyve: deprecate #67155

Merged

5 tasks

go 1.15.6

eb52828

fxcoudert force-pushed the bump-go-1.15.6 branch from 9e4fb5b to eb52828 Compare December 18, 2020 09:53

carlocab mentioned this pull request Dec 19, 2020

boost 1.75 #66792

Closed

5 tasks

carlocab mentioned this pull request Dec 19, 2020

v5.0.1 and v5.0.2 tarballs sha256 changed? gravitational/teleport#5174

Closed

carlocab mentioned this pull request Dec 19, 2020

teleport: update sha256 #67231

Closed

5 tasks

fxcoudert closed this in 798511a Dec 19, 2020

BrewTestBot added the outdated PR was locked due to age label Jan 19, 2021

Homebrew locked as resolved and limited conversation to collaborators Jan 19, 2021

go 1.15.6 #66355

go 1.15.6 #66355

Conversation

shigemk2 commented Dec 6, 2020

fxcoudert commented Dec 7, 2020

carlocab commented Dec 8, 2020

carlocab commented Dec 8, 2020

shigemk2 commented Dec 9, 2020

carlocab commented Dec 9, 2020

carlocab commented Dec 9, 2020

SMillerDev commented Dec 9, 2020

carlocab commented Dec 9, 2020

Groxx commented Dec 10, 2020

SMillerDev commented Dec 10, 2020

carlocab commented Dec 10, 2020

Loyalsoldier commented Dec 11, 2020

carlocab commented Dec 11, 2020

SMillerDev commented Dec 11, 2020

Loyalsoldier commented Dec 11, 2020 • edited Loading

mikesep commented Dec 11, 2020

carlocab commented Dec 11, 2020

carlocab commented Dec 11, 2020 • edited Loading

mikesep commented Dec 11, 2020 • edited Loading

Loyalsoldier commented Dec 11, 2020 • edited Loading

carlocab commented Dec 11, 2020

carlocab commented Dec 12, 2020 • edited Loading

SMillerDev commented Dec 12, 2020

carlocab commented Dec 12, 2020

shigemk2 commented Dec 12, 2020

carlocab commented Dec 12, 2020 • edited Loading

carlocab commented Dec 18, 2020

carlocab commented Dec 18, 2020

CI failure summary

carlocab commented Dec 18, 2020

fxcoudert commented Dec 18, 2020

andig commented Dec 18, 2020 • edited Loading

carlocab commented Dec 18, 2020

andig commented Dec 18, 2020

carlocab commented Dec 18, 2020 • edited Loading

fxcoudert commented Dec 18, 2020

arbourd commented Dec 18, 2020 • edited Loading

chenrui333 commented Dec 18, 2020

arbourd commented Dec 19, 2020

carlocab commented Dec 19, 2020 • edited Loading

carlocab commented Dec 19, 2020 • edited Loading

carlocab commented Dec 19, 2020 • edited Loading

Loyalsoldier commented Dec 19, 2020

carlocab commented Dec 19, 2020

carlocab commented Dec 19, 2020

fxcoudert commented Dec 19, 2020

carlocab commented Dec 19, 2020

fxcoudert commented Dec 19, 2020

Loyalsoldier commented Dec 11, 2020 •

edited

Loading

carlocab commented Dec 11, 2020 •

edited

Loading

mikesep commented Dec 11, 2020 •

edited

Loading

Loyalsoldier commented Dec 11, 2020 •

edited

Loading

carlocab commented Dec 12, 2020 •

edited

Loading

carlocab commented Dec 12, 2020 •

edited

Loading

andig commented Dec 18, 2020 •

edited

Loading

carlocab commented Dec 18, 2020 •

edited

Loading

arbourd commented Dec 18, 2020 •

edited

Loading

carlocab commented Dec 19, 2020 •

edited

Loading

carlocab commented Dec 19, 2020 •

edited

Loading

carlocab commented Dec 19, 2020 •

edited

Loading