ca-certificates: process the system certificates for different distros #254135
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI-skip-recursive-dependents
Contributor
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
woodruffw
reviewed
Nov 12, 2025
Comment on lines
-150
to
+157
| system_ca_certificates = Pathname.new("/etc/ssl/certs/ca-certificates.crt") | ||
| return if !system_ca_certificates.exist? || !system_ca_certificates.readable? | ||
| ca_certificate_paths = [ | ||
| "/etc/ssl/certs/ca-certificates.crt", # Debian/Ubuntu, Alpine Linux, Arch Linux | ||
| "/etc/pki/ca-trust/extracted/pem/tls-ca-bundle.pem", # RHEL/CentOS/Fedora | ||
| "/etc/ssl/ca-bundle.pem", # SUSE/openSUSE | ||
| ] | ||
| system_ca_certificates = ca_certificate_paths.map { |p| Pathname.new(p) } | ||
| .find { |pn| pn.file? && pn.readable? } | ||
| return unless system_ca_certificates |
Member
There was a problem hiding this comment.
For full generality, perhaps we could use the same set of patterns/heuristics that rustls's openssl-probe uses? I think that would be a nice future-proofing step here 🙂
https://github.com/rustls/openssl-probe/blob/main/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?The location of the system CA certificate store depends on the Linux distro. This PR adds two additional locations. The formula will pick the file that it finds first.
I can't seem to run
brew audit --strictas that command doesn't seem to respect theHOMEBREW_NO_INSTALL_FROM_API=1environment variable and the firewall I am behind blocks access tohttps://formulae.brew.sh/api/formula.jws.json.