mcp-server-kubernetes: better testing #245058
Open
+18
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
nodejs
I think that the current tests actually do not work properly. A MCP server process is a daemon that terminate on SIGTERM so i think it currently fails but with somehow the searched strings in the output. The cause of the failure is likely the `notifications/initialized` client anwser that is missing meanwhile it is required by MCP version `2025-03-26`. I have catched this error while trying to write other MCP formulae (PRs coming soon). Proposed fix: - send the missing message - send the `TERM` signal (otherwise process keep running) - parse the output to be sure to have right answer
nikaro
force-pushed
the
fix/mcp-server-kubernetes-test
branch
from
74e0746 to
682e206
Compare
|
Hum i don't why it fails on |
|
Yes i saw this, the MCP server is supposed to return two lines: the response to the initialization request, and the response to tools listing request. Why i don't understand is why it works on my machine, a M1 on macOS 26, and on the GitHub macOS arm64 runner. Do you have any tips to debug this easily instead of adding some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?I think that the current tests actually do not work properly. A MCP server process is a daemon that terminate on SIGTERM so i think it currently fails but with somehow the searched strings in the output.
The cause of the failure is likely the
notifications/initializedclient anwser that is missing meanwhile it is required by MCP version2025-03-26.I have catched this error while trying to write other MCP formulae (PRs coming soon).
Proposed fix:
TERMsignal (otherwise process keep running)