Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sage to 8.0,10.12.6 #36946

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Update sage to 8.0,10.12.6 #36946

merged 1 commit into from
Jul 25, 2017

Conversation

commitay
Copy link
Contributor

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Simplify urls to use version before/after comma

Update app, binary and add uninstall quit

@miccal miccal merged commit 9a14f40 into Homebrew:master Jul 25, 2017
@commitay commitay deleted the sage branch July 25, 2017 06:01
@commitay
Copy link
Contributor Author

@miccal Can you see #36947? I commented and closed the PR but it seems to have disappeared?

@miccal
Copy link
Member

miccal commented Jul 25, 2017

@commitay no I cannot?

@commitay
Copy link
Contributor Author

commitay commented Jul 25, 2017

Weird. The Github page for the person that opened the PR 404s https://github.com/BenjaminHCCarr

The PR is still in my notifications but it 404s. I didn't think PRs could just disappear.

github

@commitay
Copy link
Contributor Author

commitay commented Jul 25, 2017

This is really weird, they are an active contributor but I can't find a PRs authored by them or any issues opened by them.

Commits seem to still be accessible but the PRs and issues 404.

9a2aadc

Issue: #26345
Google cache: https://webcache.googleusercontent.com/search?q=cache:n-eLwXSkC1QJ:https://github.com/caskroom/homebrew-cask/issues/26345+&cd=1&hl=en&ct=clnk&gl=au

@commitay
Copy link
Contributor Author

Must have been a Github glitch, all PRs and issues are working again.

@BenjaminHCCarr
Copy link
Contributor

Not glitch github locked my account....

I got "Flagged" / Locked / Private
Thinking it's @keybaseio related keybase/proofs#39

@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants