Skip to content

Conversation

@andmev
Copy link
Contributor

@andmev andmev commented Dec 1, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Verified checksums and URLs for both Apple Silicon and Intel architectures.

@andmev andmev force-pushed the add-nanoleaf-desktop branch from 88ca322 to 6b36e87 Compare December 1, 2025 18:43
p-linnane
p-linnane previously approved these changes Dec 1, 2025
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @andmev! Thanks!

Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor changes to conform with our styling.

@p-linnane p-linnane dismissed their stale review December 1, 2025 21:34

Minor styling fixes needed

@p-linnane p-linnane changed the title nanoleaf-desktop 2.3.4 (new cask) nanoleaf 2.3.4 (new cask) Dec 1, 2025
andmev and others added 2 commits December 2, 2025 11:16
Co-authored-by: Patrick Linnane <[email protected]>
Co-authored-by: Patrick Linnane <[email protected]>
@andmev andmev requested a review from p-linnane December 2, 2025 10:17
Copy link
Member

@p-linnane p-linnane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andmev!

@p-linnane p-linnane added this pull request to the merge queue Dec 2, 2025
Merged via the queue into Homebrew:main with commit 712d19b Dec 2, 2025
15 checks passed
@andmev andmev deleted the add-nanoleaf-desktop branch December 3, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants